Repository navigation
Conversation
Expand workspace configurations before resolving individual builds. Reuse tsdown's member discovery and config loading so filters and watch restarts see the selected packages. Cover root configuration exclusions, the CLI workspace override and selection by package name with a two-member fixture.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
vp pack --workspace 'packages/*'from a library workspace can build only the root entry and exit successfully. Selecting workspace members throughpack.workspacehas the same problem. A member-name filter can then leave the build with no output.Expand each workspace pack configuration before resolving and filtering individual builds. A patch to the pinned tsdown dependency exposes its existing workspace resolver so the CLI can reuse its member config loading and track those files in watch mode.
Evidence
vp checkpassed. The unit suite passed 3,403 tests with one skipped.Merge Danger
Door: Two-way. The CLI change and dependency patch can be reverted together.
Blast Radius: Pack. The patch targets tsdown 0.23.4 and needs review when that dependency changes.