Skip to content

fix(pack): build selected workspace members - #3378

Draft
SaKaNa-Y wants to merge 1 commit into
voidzero-dev:mainfrom
SaKaNa-Y:fix/pack-workspace-members
Draft

SaKaNa-Y wants to merge 1 commit into
voidzero-dev:mainfrom
SaKaNa-Y:fix/pack-workspace-members

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Running vp pack --workspace 'packages/*' from a library workspace can build only the root entry and exit successfully. Selecting workspace members through pack.workspace has the same problem. A member-name filter can then leave the build with no output.

Expand each workspace pack configuration before resolving and filtering individual builds. A patch to the pinned tsdown dependency exposes its existing workspace resolver so the CLI can reuse its member config loading and track those files in watch mode.

vite.config → workspace members → member configs → filter → build

Evidence

  • On 1.5.0 the regression fixture produced a root bundle with value 99. The new CLI snapshot checks the actual member exports (11 and 55), an exclusion, a CLI override and a single-member filter. It also checks that no root bundle exists.
  • A syntax error in the selected member exited 1. Fixing the entry restored the build. Editing a member config in watch mode rebuilt the renamed output.
  • The focused CLI snapshot and repository-wide vp check passed. The unit suite passed 3,403 tests with one skipped.

Merge Danger

Door: Two-way. The CLI change and dependency patch can be reverted together.

Blast Radius: Pack. The patch targets tsdown 0.23.4 and needs review when that dependency changes.

Expand workspace configurations before resolving individual builds. Reuse tsdown's member discovery and config loading so filters and watch restarts see the selected packages.

Cover root configuration exclusions, the CLI workspace override and selection by package name with a two-member fixture.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant