Repository navigation
Conversation
SaKaNa-Y
marked this pull request as ready for review
November 6, 2026 12:39
Contributor
Author
|
When users set As a separate improvement, can we warn users when they explicitly configure non-empty prefixes but none match any environment variables? This can help users spot spelling mistakes or missing environment variables. An empty result can also be intentional, so the warning can leave the build running. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A library sets
pack.envFileandpack.envPrefix: ['CUSTOM_']to embed custom build values. Runningvp packwithout--env-prefixignores that prefix and usesVITE_PACK_andTSDOWN_instead. The build succeeds, but custom values remain unresolved and excluded default-prefixed values enter the bundle.Apply defaults after merging CLI options with each pack configuration:
This preserves empty arrays and distinct prefixes across multiple pack configurations.
Evidence
After: The same assertion passes.
vp checkand unit tests still report missing generated artifacts; the unit suite also reports a core build-artifact snapshot mismatch.Merge Danger
Door: Two-way
The change can be reverted without a migration.
Blast Radius: Pack
Builds with a configured
pack.envPrefixnow use that filter when no CLI override is supplied. These builds can produce different output because the configured variables replace the previously selected default-prefixed variables.