Skip to content

refactor(command): remove the relative PATH workaround - #2583

Draft
RSS1102 wants to merge 1 commit into
voidzero-dev:mainfrom
RSS1102:rss1102/refactor-remove-relative-path-workaround
Draft

refactor(command): remove the relative PATH workaround#2583
RSS1102 wants to merge 1 commit into
voidzero-dev:mainfrom
RSS1102:rss1102/refactor-remove-relative-path-workaround

Conversation

@RSS1102

@RSS1102 RSS1102 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update which to 8.0.6, which includes relative PATH resolution against the provided cwd
  • remove the Vite+ relative PATH workaround and delegate binary lookup directly to which::which_in
  • retain behavior-level coverage for relative entries, lookup order, Unix edge cases, explicit relative programs, and the cross-platform CLI snapshot

Closes #2482

Testing

  • cargo test -p vp_command
  • cargo test -p vp_cli_snapshots -- command_exec_relative_path_cwd
  • cargo fmt --all -- --check
  • cargo check --workspace --all-features --all-targets --locked
  • workspace Clippy with the repository flags and --deny warnings
  • cargo test --manifest-path crates/vp_trampoline/Cargo.toml
  • pnpm build

The CLI snapshot was verified locally on macOS. The existing Windows PTY snapshot CI job will run the same command_exec_relative_path_cwd fixture on a Windows runner.

@netlify

netlify Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 54a4d93
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a94701e2f75e500089537f0

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​which@​8.0.5 ⏵ 8.0.69910093100100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(command): remove the relative PATH workaround after the which-rs release

1 participant