Skip to content

fix(check): preserve oxlint GitHub reporter #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wyf027 wants to merge 3 commits into from
Closed

fix(check): preserve oxlint GitHub reporter #1890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f169521
fix(check): preserve oxlint github reporter
wyf027 Jun 19, 2026
e64dab1
fix(check): keep lint output parseable for agents
wyf027 Jun 21, 2026
3c9add1
fix(check): remove forced oxlint default reporter
wyf027 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/cli/binding/src/check/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@ pub(crate) async fn execute_check(
if fix && lint_enabled {
args.push("--fix".to_string());
}
// `vp check` parses oxlint's human-readable summary output to print
// unified pass/fail lines. When `GITHUB_ACTIONS=true`, oxlint auto-switches
// to the GitHub reporter, which omits that summary on success and makes the
// parser think linting never started. Force the default reporter here so the
// captured output is stable across local and CI environments.
args.push("--format=default".to_string());
if !lint_enabled && type_check_enabled {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve a parseable lint format for agent runs

When vp check runs under an AI agent environment such as Codex or Claude (CODEX_THREAD_ID, CLAUDE_CODE, etc.), removing the forced format lets oxlint choose its default agent formatter; I checked oxlint v1.70 and default_output_format returns OutputFormat::Agent when is_agent() is true, while the Agent reporter is explicitly “no summary”. analyze_lint_output still requires Found ... and Finished ..., so a successful lint phase is reported as Linting could not start and real diagnostics are classified as startup failures in exactly the environments that run vp check from AGENTS.md. Please keep forcing a parseable format outside GitHub Actions, or explicitly request github only when GITHUB_ACTIONS=true.

Useful? React with 👍 / 👎.

args.push("--type-check-only".to_string());
}
Expand Down
Loading