Skip to content

mesa: update to 22.3.5.#41084

Closed
ardadem wants to merge 2 commits into
void-linux:masterfrom
ardadem:pr-mesa-22.3
Closed

mesa: update to 22.3.5.#41084
ardadem wants to merge 2 commits into
void-linux:masterfrom
ardadem:pr-mesa-22.3

Conversation

@ardadem
Copy link
Copy Markdown
Contributor

@ardadem ardadem commented Dec 14, 2022

Testing the changes

  • I tested the changes in this PR: YES

Draft until 22.3.1.
Feel free to review and test it meantime.

@ardadem ardadem marked this pull request as draft December 14, 2022 13:28
@zlice
Copy link
Copy Markdown
Contributor

zlice commented Dec 15, 2022

Was just about to make a PR. 22.3.1 has a bunch of Intel fixes. Switching to that instead of git-latest but so far it's been great.

@ardadem ardadem changed the title mesa: update to 22.3.0. mesa: update to 22.3.1. Dec 15, 2022
@ardadem ardadem marked this pull request as ready for review December 15, 2022 05:38
This was referenced Dec 16, 2022
@biopsin
Copy link
Copy Markdown
Contributor

biopsin commented Dec 17, 2022

fixes gallium issue for AMD Aruba introduced in 22.2.x

../src/gallium/drivers/r600/r600_state_common.c:961 r600_shader_select - Failed to build shader variant (type=1) -1 EE ../src/gallium/drivers/r600/r600_shader.c:193 r600_pipe_shader_create - translation from TGSI failed !

@ardadem ardadem force-pushed the pr-mesa-22.3 branch 2 times, most recently from 96bd8ce to 7c8ea94 Compare December 19, 2022 20:50
@simvux simvux mentioned this pull request Dec 22, 2022
16 tasks
@bubba-champion
Copy link
Copy Markdown
Contributor

I think we should move /usr/share/vulkan/icd.d/radeon_icd.i686.json from mesa-vulkan-radeon to mesa-vulkan-radeon-32bit, and do the same with mesa-vulkan-intel. Also, I suppose we can move /usr/share/drirc.d/00-radv-defaults.conf from mesa to mesa-vulkan-radeon.

@vincele
Copy link
Copy Markdown
Contributor

vincele commented Dec 23, 2022

I tested this on x86_64, Radeon RX 550.
Desktop, browsing, glmark2, extreme tux racer.
Works OK

@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Dec 23, 2022

I think we should move /usr/share/vulkan/icd.d/radeon_icd.i686.json from mesa-vulkan-radeon to mesa-vulkan-radeon-32bit, and do the same with mesa-vulkan-intel.

It is on purpose, there is a comment about that on the template;

# ensure that each eligible architecture ships its multilib icd files
# in some cases, multiple counterpart architectures may exist (aarch64)
# this allows us to not have to ship these files in the current *-32bit packages

Also, I suppose we can move /usr/share/drirc.d/00-radv-defaults.conf from mesa to mesa-vulkan-radeon.

This is how it should be, thanks for the feedback.

@bubba-champion
Copy link
Copy Markdown
Contributor

bubba-champion commented Dec 24, 2022

Works well on RX 6400 (x86_64-glibc) in steam games (DXVK, native), and with multimedia (mpv).

@bubba-champion
Copy link
Copy Markdown
Contributor

@ardadem ardadem changed the title mesa: update to 22.3.1. mesa: update to 22.3.2. Dec 30, 2022
@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Jan 3, 2023

Regular rebase.

@Seltyk
Copy link
Copy Markdown
Contributor

Seltyk commented Jan 11, 2023

22.3.3 was released today; consider bumping

@ardadem ardadem changed the title mesa: update to 22.3.2. mesa: update to 22.3.3. Jan 11, 2023
@motorto
Copy link
Copy Markdown
Contributor

motorto commented Jan 17, 2023

From my testing the lto is only broken currently on x86_64 so probably we could disable lto only for x86_64 and enable for all the others archs. (Yeah I was working on updating this package, wihtout looking for active PR's) also bump it to x86_64

# lto fails on x86 only, no need to disable on all archs
case "$XBPS_TARGET_MACHINE" in
	x86_64*) configure_args+=" -Db_lto=false" ;;
	*) configure_args+=" -Db_lto=true" ;;
esac

@JamiKettunen
Copy link
Copy Markdown
Contributor

JamiKettunen commented Jan 17, 2023

@motorto LTO is enabled by default by the meson build-style, no need to re-enable it on the non-x86_64 arches on your example: https://github.com/void-linux/void-packages/blob/cc6491d/common/build-style/meson.sh#L123

nvm I just looked at the template and it sets -Db_lto=false in configure_args

@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Jan 17, 2023

From my testing the lto is only broken currently on x86_64 so probably we could disable lto only for x86_64 and enable for all the others archs. (Yeah I was working on updating this package, wihtout looking for active PR's) also bump it to x86_64

# lto fails on x86 only, no need to disable on all archs
case "$XBPS_TARGET_MACHINE" in
	x86_64*) configure_args+=" -Db_lto=false" ;;
	*) configure_args+=" -Db_lto=true" ;;
esac

it is disabled only on x86_64 i686 now

@motorto
Copy link
Copy Markdown
Contributor

motorto commented Jan 17, 2023

@motorto Not really, LTO works well with x86_64 but it fails on i686. I think you got confused on that.

Hum weird, unless x86 on alpine only refers to i686 ...

https://git.alpinelinux.org/aports/tree/main/mesa/APKBUILD#n107

@JamiKettunen
Copy link
Copy Markdown
Contributor

Hum weird, unless x86 on alpine only refers to i686 ...

@motorto It does, see https://wiki.alpinelinux.org/wiki/Architecture & https://dl-cdn.alpinelinux.org/alpine/edge/main/

@lemmi
Copy link
Copy Markdown
Member

lemmi commented Jan 21, 2023

Have been running it for about 2 days. Too bad upstream didn't merge radeonsi support for rusticl yet https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19232

@motorto
Copy link
Copy Markdown
Contributor

motorto commented Jan 24, 2023

Using it the last week and it works fine on my side !

@bubba-champion
Copy link
Copy Markdown
Contributor

https://gitlab.freedesktop.org/mesa/mesa/-/tags/mesa-22.3.4

@ardadem ardadem changed the title mesa: update to 22.3.3. mesa: update to 22.3.4. Jan 27, 2023
@HadetTheUndying
Copy link
Copy Markdown
Contributor

This update caused gnome to break in a number of ways. I'm going to take some disk snapshots tomorrow and then I'll post screenshots. I verified it was this update by rolling back mesa. If someone else that has more time than i do would like to test I would appreciate it.

@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Jan 28, 2023

@HadetTheUndying by "this update" you mean 22.3.4? Can you also try build with -Db_lto=false.< Can you try now?

@bubba-champion
Copy link
Copy Markdown
Contributor

I can confirm with -Db_lto=false all works fine, but without it gnome interface completely broken.

@motorto
Copy link
Copy Markdown
Contributor

motorto commented Jan 28, 2023

Don't use gnome myself, but that's weird, going to spin a vm to check why, meanwhile it looks okay to disable lto

@HadetTheUndying
Copy link
Copy Markdown
Contributor

@HadetTheUndying by "this update" you mean 22.3.4? Can you also try build with -Db_lto=false.< Can you try now?

I won't have a chance to test until Monday. I hadn't done any system maintenance in awhile so unfortunately i didn't do a very good test case when I rolled back since i also reinstalled gnome, xorg and all that jazz. I'll take a snapshot of my disk Sunday night and then do the upgrade again.

@Piraty
Copy link
Copy Markdown
Member

Piraty commented Jan 31, 2023

@JamiKettunen @jcgruenhage might be interested to know that mesa-22.3.3 and mesa-22.3.4 have a bug affecting the pinephone

@HadetTheUndying
Copy link
Copy Markdown
Contributor

I can confirm with -Db_lto=false all works fine, but without it gnome interface completely broken.

Just for reference you experienced the font rendering problems and just general black display blocks? I haven't had time to do any testing since my initial report.

@bubba-champion
Copy link
Copy Markdown
Contributor

I can confirm with -Db_lto=false all works fine, but without it gnome interface completely broken.

Just for reference you experienced the font rendering problems and just general black display blocks? I haven't had time to do any testing since my initial report.

I experienced problems with font rendering, and also artifacts in the steam overlay while playing.

@HadetTheUndying
Copy link
Copy Markdown
Contributor

I can confirm with -Db_lto=false all works fine, but without it gnome interface completely broken.

Just for reference you experienced the font rendering problems and just general black display blocks? I haven't had time to do any testing since my initial report.

I experienced problems with font rendering, and also artifacts in the steam overlay while playing.

Just to clarify, disabling LTO fixed that? I'll have some time to test over the weekend. Mesa 23 is likely just around the corner at this point though.

@bubba-champion
Copy link
Copy Markdown
Contributor

I can confirm with -Db_lto=false all works fine, but without it gnome interface completely broken.

Just for reference you experienced the font rendering problems and just general black display blocks? I haven't had time to do any testing since my initial report.

I experienced problems with font rendering, and also artifacts in the steam overlay while playing.

Just to clarify, disabling LTO fixed that? I'll have some time to test over the weekend. Mesa 23 is likely just around the corner at this point though.

Yes, as I wrote earlier, -Db_lto=false fixes all the above problems.

@ardadem ardadem changed the title mesa: update to 22.3.4. mesa: update to 22.3.5. Feb 14, 2023
@motorto
Copy link
Copy Markdown
Contributor

motorto commented Feb 14, 2023

Fedora has this patch: https://src.fedoraproject.org/rpms/mesa/blob/rawhide/f/gnome-shell-glthread-disable.patch

Can you enable lto again with this patch ?

@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Feb 14, 2023

Fedora has this patch: https://src.fedoraproject.org/rpms/mesa/blob/rawhide/f/gnome-shell-glthread-disable.patch

Can you enable lto again with this patch ?

It is not gnome related, i've also experienced it on WM.

Also Fedora keeps LTO disabled. See https://src.fedoraproject.org/rpms/mesa/blob/rawhide/f/mesa.spec#_341.

@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Feb 14, 2023

https://gitlab.freedesktop.org/mesa/mesa/-/issues/7743

It is actually broken but sometimes it is not.

Given that the commits which (un)break things with LTO tend to be not directly related to any code actually used on the affected setup, there seem to be other bigger factors than the specific commit. I'd say any commit which exists today has to be assumed to be potentially affected.

Anyways, we should keep it disabled.

Mesa is known to hit various issues with LTO, I'd recommend disabling it for now.

* remove obsolete add-elf-use-tls patch
* remove xvmc
* build intel_hasvk vulkan driver for older intel GPUs
* build rusticl opencl implementation
@ardadem
Copy link
Copy Markdown
Contributor Author

ardadem commented Feb 19, 2023

@JamiKettunen @jcgruenhage might be interested to know that mesa-22.3.3 and mesa-22.3.4 have a bug affecting the pinephone

Should be fixed now.

@Piraty Piraty closed this in dabdc21 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.