fix(etl): exclude technique-jsonb fields from metric auto-capture - #8
Merged
Conversation
`max_num_batched_tokens` and `num_speculative_tokens` are TECHNIQUE_KEYS
extracted into BenchmarkParams.techniques by parseTechniques. But they
weren't in NON_METRIC_KEYS, so benchmark-mapper's metrics loop ALSO
captured them as numeric metrics, producing:
[WARN] auto-captured unexpected metric 'max_num_batched_tokens'
— add to METRIC_KEYS … or NON_METRIC_KEYS
Net effect: same value in both `techniques` and `metrics` JSONB columns.
Wasted space and a confusing warning.
Add all technique-flag artifact keys to NON_METRIC_KEYS so they live
only in techniques.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two new gemma4 ingests produced WARN lines like:
```
[WARN] auto-captured unexpected metric 'max_num_batched_tokens'
[WARN] auto-captured unexpected metric 'num_speculative_tokens'
```
`parseTechniques` correctly routes these fields into `BenchmarkParams.techniques`, but the metric-auto-capture loop in `benchmark-mapper.ts` also picked them up because they weren't in `NON_METRIC_KEYS`. Result: same value stored in both `techniques` and `metrics` jsonb columns.
Fix: add the four technique-jsonb keys to `NON_METRIC_KEYS` so they're routed exclusively into techniques.
Test plan
🤖 Generated with Claude Code