This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Repository navigation
Conversation
ryzhyk
approved these changes
Feb 7, 2023
Signed-off-by: Ben Pfaff <bpfaff@vmware.com>
Add derive's for `Encode` and `Decode` in the `orgchart` example, so that it compiles with persistence enabled.
I didn't understand that the difference between 'join' and 'join_index' was that the latter indexes the output stream. The example did not use the index, so we can omit it. This commit does so. Signed-off-by: Ben Pfaff <bpfaff@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a resubmission of PR #286 with the additional fix commits from that PR already applied. It is being resubmitted because currently the CI/CD pipeline only works with branches in the main DBSP repo, whereas PR #286 came from my fork.
Signed-off-by: Ben Pfaff bpfaff@vmware.com