Skip to content

Add started_at, distance_values and position_values#23

Merged
vkurup merged 7 commits intovkurup:masterfrom
janpipek:master
Oct 11, 2019
Merged

Add started_at, distance_values and position_values#23
vkurup merged 7 commits intovkurup:masterfrom
janpipek:master

Conversation

@janpipek
Copy link
Contributor

@janpipek janpipek commented Mar 9, 2019

If you want to draw your track on a map or plot distance vs. altitude, distance_values and position_values are necessary. I am also adding started_at for completeness as for some people (me?), this might be more relevant than completed_at.

Hope that this helps to improve your lib. Please consider whether the position format as (lat, lon) tuple is suitable.

@janpipek janpipek changed the title Add distance_values and position_values Add started_at, distance_values and position_values Mar 9, 2019
@janpipek
Copy link
Contributor Author

janpipek commented Mar 9, 2019

Note: I am testing the library against TCX files exported from Polar Flow. Hope that brings another level of compatibility.

@vkurup
Copy link
Owner

vkurup commented Oct 11, 2019

Thank you for your contribution. I personally don't use this library much, but I see the value of the features that you've added. 💯 (I'll fix the 'lint' error that TravisCI is reporting in a separate commit)

@vkurup vkurup merged commit b2cdd4b into vkurup:master Oct 11, 2019
@janpipek
Copy link
Contributor Author

You are welcome. I don't use the library on daily basis either, but being able to read my Polar exports is always useful.

All the best,
Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants