Add started_at, distance_values and position_values#23
Merged
vkurup merged 7 commits intovkurup:masterfrom Oct 11, 2019
Merged
Conversation
Contributor
Author
|
Note: I am testing the library against TCX files exported from Polar Flow. Hope that brings another level of compatibility. |
Owner
|
Thank you for your contribution. I personally don't use this library much, but I see the value of the features that you've added. 💯 (I'll fix the 'lint' error that TravisCI is reporting in a separate commit) |
Contributor
Author
|
You are welcome. I don't use the library on daily basis either, but being able to read my Polar exports is always useful. All the best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want to draw your track on a map or plot distance vs. altitude,
distance_valuesandposition_valuesare necessary. I am also addingstarted_atfor completeness as for some people (me?), this might be more relevant thancompleted_at.Hope that this helps to improve your lib. Please consider whether the position format as (lat, lon) tuple is suitable.