Repository navigation
feat: provide context to beforeAll, afterAll and aroundAll hooks - #9553
Closed
sheremet-va wants to merge 1 commit into
Closed
sheremet-va wants to merge 1 commit into
sheremet-va wants to merge 1 commit into
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
Member
Author
|
This proves to be rather difficult... |
sheremet-va
force-pushed
the
01-29-feat_provide_context_to_beforeall_afterall_and_aroundall_hooks
branch
from
January 29, 2026 20:34
a3cde95 to
4b720c3
Compare
sheremet-va
force-pushed
the
01-29-feat_provide_context_to_beforeall_afterall_and_aroundall_hooks
branch
from
January 29, 2026 20:42
4b720c3 to
52b819d
Compare
hi-ogawa
reviewed
Jan 30, 2026
hi-ogawa
left a comment
hi-ogawa
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. A bit confused by override fixture and suite hook fixture, but seems reasonable. While testing around, I found a few more test cases which might be beneficial.
| expect(tests).toMatchInlineSnapshot(`" ✓ basic.test.ts > test1 <time>"`) | ||
| }) | ||
|
|
||
| test('test.override fixtures are scoped to their suite in beforeAll/afterAll', async () => { |
Collaborator
There was a problem hiding this comment.
Can you add test cases with reverse order? The behavior turns out to be the same.
extendedTest.beforeAll({ value }) ...)
extendedTest.override('value', ...)
sheremet-va
changed the base branch from
01-29-feat_support_type_inference_with_new_test.extend_syntax
to
graphite-base/9553
January 30, 2026 07:57
Collaborator
|
What I found while testing around was this #9555. Created a separate issue since it was same on main. |
Member
Author
Member
Author
This was referenced Jan 30, 2026
sheremet-va
deleted the
01-29-feat_provide_context_to_beforeall_afterall_and_aroundall_hooks
branch
May 26, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #issue-number
Next PR - timeout in fixtures,
mergeTestsand maybe refactor of fixture support - I get lost in what is going in this feature at this pointPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.