Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 of 2 tasks
Collaborator
Author
|
This appears less immediate need than #11232 so closing. Feel free to take over if any interest or create a new issue request if there's a need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: review
TestCase.attempts()from #11232 fills in while a test runs, but no reporter hook fires when a single run finishes, and the existingtest-retriedevent never reaches a reporter hook. This PR adds atest-attempt-finishedrunner event that is sent after every retry and repeat run. It carries that run'sattemptand calls a newonTestCaseAttempt(testCase, attempt)reporter hook.test-retriedis kept but marked deprecated.Because the event carries its own
attempt, the hook always gets the right run even though task updates are batched. Tests configured withretryorrepeatsalso send the batch immediately after each attempt, sotestCase.attempts()inside the hook ends with that attempt. Tests that run only once keep the normal 100ms batching, so they don't pay for an extra message.test-attempt-finishedevent with{ attempt }dataonTaskUpdateRPC--merge-reportsconvertTasksToEventsreplays one event per saved attempt beforetest-finished🤖 Generated with Claude Code