Repository navigation
fix(types): make public declarations self-contained - #11141
Merged
sheremet-va merged 1 commit intoSep 4, 2026
Merged
Conversation
sheremet-va
approved these changes
Sep 4, 2026
Member
|
LGTM, thanks |
scrollDynasty
added a commit
to scrollDynasty/BrowserMesh
that referenced
this pull request
Sep 7, 2026
Dependabot raised vitest to 5.0.0 but left @vitest/coverage-v8 on ^4.1.10, which pins peer vitest@4.1.11 exactly. Every CI job failed at `npm ci` with ERESOLVE before running a single check. Bump @vitest/coverage-v8 to ^5.0.0 alongside it, and move vitest.config.ts to its own tsconfig with skipLibCheck. Vitest 5.0.0 ships three declaration files that do not compile under this project's settings - a stale `@vitest/expect` type import and an unexported `MarkOptions`, both vitest-dev/vitest#11140, fixed by vitest-dev/vitest#11141 but unreleased; plus a `benchmark.provider` optionality clash under exactOptionalPropertyTypes. Confining skipLibCheck to the one file that imports `vitest/config` keeps src, tests and scripts on the strict, full-library check. All 245 tests pass on Vitest 5 and coverage stays above every threshold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vitest/expectimport from the public config declarationMarkOptionsandBrowserTraceEntryKindthrough the core browser typesvitest/browserCloses #11140
Tests
pnpm lint:fixpnpm --filter @vitest/browser build:nodepnpm --filter @vitest/test-integration-dts-config testpnpm --filter @vitest/test-integration-dts-browser-playwright test@vitest/expector a browser providerAI disclosure
This change was prepared with assistance from OpenAI Codex GPT 5.6sol and manually reviewed before submission.