Repository navigation
Conversation
3 of 7 tasks
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 of 7 tasks
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
hi-ogawa
force-pushed
the
refactor-html-reproter-module-graph
branch
from
May 19, 2026 01:12
e816a61 to
cfbb58c
Compare
…ter-module-graph Resolve conflicts and follow main changes: - browser mode uses `project.vite.environments.client` (vitest-dev#10386), so drop the separate browser graph and select the environment by `viteEnvironment` or project default - move client-side types and `deriveModuleGraphData` to `utils/serialized-module-graph.ts` so the UI client does not typecheck node sources - test that the html report module graph equals `getModuleGraph` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Reviving the PR since this take looked more promising than #11419. |
…n a serialized shell Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Module graph ids are resolved file paths, so `/@fs/` only appears in urls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- utils/module-graph: shared types, test file graph query, serialized shell - node/module-graph: live getModuleGraph, serialize and restore project modules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
closing in favor of #11421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html reporter stored a full
ModuleGraphDataper test file, so the report grew with test files × modules and crashedflatted.stringifywithRangeError: Invalid string length. Now it stores the module graph the way the blob reporter does, once per project and Vite environment, and the static client derives each test file's graph on demand.Compared with #11419 (both measured on the same repro, before: 421 MB / 24 MB, 3.1 GB,
RangeError):serializeProjectModules)ModuleGraphData+ per-filerootsgetModuleGraph+deriveModuleGraphData(test checks they agree)createModuleGraphCollector; client only walks reachability--merge-reports+ htmlexternalizedlose?v=hash(snapshot change)On Vitest's own
test/unitreport the effect is small (graph 798 KB → 327 KB, total about 3%), because thefilestask data dominates there.