fix: check file existence after path resolution

packages/launch-editor/index.js

@@ -16,6 +16,7 @@
 const guessEditor = require('./guess')
 const getArgumentsForFile = require('./get-args')
 const constructWindowsLaunchCommand = require('./construct-windows-launch-command')
+const parseFile = require('./parse-file')
 
 function wrapErrorCallback(cb) {
   return (fileName, errorMessage) => {
@@ -42,24 +43,6 @@
   return false
 }
 
-const positionRE = /:(\d+)(:(\d+))?$/
-function parseFile(file) {
-  // support `file://` protocol
-  if (file.startsWith('file://')) {
-    file = require('url').fileURLToPath(file)
-  }
-
-  const fileName = file.replace(positionRE, '')
-  const match = file.match(positionRE)
-  const lineNumber = match && match[1]
-  const columnNumber = match && match[3]
-  return {
-    fileName,
-    lineNumber,
-    columnNumber,
-  }
-}
-
 let currentChildProcess = null
 
 function launchEditor(file, specifiedEditor, onErrorCallback) {
@@ -72,7 +55,7 @@
 
   onErrorCallback = wrapErrorCallback(onErrorCallback)
 
-  if (process.platform === 'win32' && path.resolve(fileName).startsWith('\\\\')) {
+  if (process.platform === 'win32' && fileName.startsWith('\\\\')) {
     return onErrorCallback(
       fileName,
       'UNC paths are not supported on Windows to avoid security issues. ' +
@@ -102,7 +85,7 @@
 
   if (process.platform === 'win32') {
     const launchCommand = constructWindowsLaunchCommand(editor, args)
     currentChildProcess = childProcess.exec(launchCommand, {
       stdio: 'inherit',
       shell: true,
     })

packages/launch-editor/parse-file.js

@@ -0,0 +1,23 @@
+const path = require('path')
+
+const positionRE = /:(\d+)(:(\d+))?$/
+
+module.exports = function parseFile(file) {
+  // support `file://` protocol
+  if (file.startsWith('file://')) {
+    file = require('url').fileURLToPath(file)
+  }
+
+  const unresolvedFileName = file.replace(positionRE, '')
+  const fileName = unresolvedFileName ? path.resolve(unresolvedFileName) : ''
+
+  const match = file.match(positionRE)
+  const lineNumber = match && match[1]
+  const columnNumber = match && match[3]
+
+  return {
+    fileName,
+    lineNumber,
+    columnNumber,
+  }
+}

packages/launch-editor/parse-file.test.js

@@ -0,0 +1,30 @@
+const assert = require('node:assert/strict')
+const { describe, test } = require('node:test')
+const path = require('node:path')
+
+const parseFile = require('./parse-file.js')
+
+describe('launchEditor path resolution', () => {
+  test('does not resolve an empty file name to the working directory', () => {
+    assert.equal(parseFile(':1:1').fileName, '')
+  })
+
+  test('resolves relative file names', () => {
+    assert.deepEqual(parseFile(`.${path.sep}file.js:1:1`), {
+      fileName: path.resolve('file.js'),
+      lineNumber: '1',
+      columnNumber: '1',
+    })
+  })
+
+  test('resolves a parent-directory component created by a position suffix', () => {
+    const project = path.resolve('project')
+    const file = `${project}${path.sep}attacker-controlled${path.sep}..:1:1`
+
+    assert.deepEqual(parseFile(file), {
+      fileName: project,
+      lineNumber: '1',
+      columnNumber: '1',
+    })
+  })
+})