Repository navigation
Add conditional requeue and repin and a versions search - #5
Merged
Merged
Conversation
Requeue takes templateVersion, expectedVersion and send; repin takes expectedVersion. POST /api/v1/notifications/versions lists ids and version tokens for a composable filter. Refusals carry details.reason, /capabilities reports the four action keys, and an option the configured service cannot take is a 409 UNSUPPORTED. openapi.yaml matches vintasend-ts-api 1.0.0-alpha12. Needs vintasend 3.8.0.
With the API reading a replica, a version listed there moves the notification on the primary, and a replica keeping tokens of its own reports versions.filter false. The README explains replica reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Conditional requeue and repin and a notification versions search, matching
vintasend-ts-apialpha12.openapi.yamlis unchanged and byte-identical to the TS sibling./capabilitiesreportsrepin.expectedVersion,requeue.expectedVersion,requeue.templateVersionandversions.filter, negotiated from the configured service.expectedVersion(andtemplateVersionon requeue); refusals carrydetails.reason(CHANGED,UNSUPPORTED, ...).Downstream impact
The dashboard reads these through the existing contract. Needs
vintasend3.8.0 (pin moves at release).Breaking?
Additive, except the requeue response, which now returns the notification after its send (
SENT,FAILEDorPENDING_SEND) instead of alwaysPENDING_SEND.Checks
pytest (355 passed),
ruff,mypy, against the local vintasend 3.8.0 tree.🤖 Generated with Claude Code