Open
Conversation
added 3 commits
March 23, 2011 00:00
Added a .gitignore file to ignore tags since they are autogenerated. Fixed the substitute section to use a different delimiter that handles commands that return newlines and other things better. A lot of common commands and subs were failing because they had slashes contained and that would throw substitute off. A better approach might be to use substitute() instead. added a global option to allow loose filetype matching so you don't have to include an underscore in the filename to get it to match a sub-filetype skeleton. It's turned off by default.
move the tags file to a tags directory under ~/.vim/skeleton this keeps the user defined tags away from plugin tags (allowing the plugin to potentionally set them one day). It also keeps them out of the repo if someone has it cloned to their .vim directory (very common with pathogen).
Cleaned up whitespace from end of lines make it handle a missing tagfile better
ellethee
reviewed
May 9, 2022
ellethee
left a comment
ellethee
left a comment
There was a problem hiding this comment.
Did I really not notice this pull request all this time?
Sorry
ellethee
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loved this plugin and your approach with the subfiles based on filetype. I added a few things, one the replace on the tags didn't handle paths well so I changed the delimiter, also setup a loose filetype match that you can enable. I moved the tags file to under the skeleton directory so it stays out of the repo when people add their own tags and whatnot. I tried to break it up into commits so if you wish to cherry-pick or whatever that's fine. Documentation updates are included.
Thanks!
C