Enforce service-bound Nexus clients during operation execution - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Service, which can cause routing and authorization mistakes.Description
NexusClientto carry the originating service identity via a newserviceNamefield and updated(*Service).NewClientto populate it.validateServiceMatch(opName string, opService *Service, c *NexusClient) errorthat checks for a nil client and enforces thatc.serviceNamematchesop.service.SyncOperation.ExecuteandAsyncOperation.Execute, and chose topanicwith an explicit message when validation fails becauseExecutereturns aworkflow.NexusOperationFutureand cannot return an error.nexus_test.go(TestOperationExecutePanicsOnMismatchedClientService) that cover mismatched-client usage for sync and async operations, overlapping operation names, and a nil-client case, and included error messages with operation and service names.Testing
go test ./...and all tests passed.TestOperationExecutePanicsOnMismatchedClientServiceverifies sync/async mismatched-client panics and nil-client panic and succeeded.Codex Task