Add ControlBuilder.Memory#192
Merged
alexrp merged 2 commits intovezel-dev:masterfrom Aug 19, 2024
Merged
Conversation
alexrp
reviewed
Aug 14, 2024
Member
|
I don't have any particular problem with taking this change, but just out of curiosity, what's the situation that made the |
Contributor
Author
|
The use case is when wanting to pass A good example of this is |
8353b4a to
643a185
Compare
alexrp
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span<>isn't available inside of an async method, which makes it more difficult to useControlBuilderwithout an alloc.The underlying type is
ArrayBufferWriter<>, which exports aMemory, so this change just exposes that API toControlBuilderas well.