Repository navigation
Backport #4537: [builders] Keep JSON import attributes and stop bundling serde-checker - #4542
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e3dfd0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
VaguelySerious
approved these changes
Sep 30, 2026
SWC and esbuild both dropped `with { type: 'json' }`, so an externalized
JSON import crashed Node's ESM loader with ERR_IMPORT_ATTRIBUTE_MISSING.
Fast discovery also matched serde patterns inside string literals, which
pulled @workflow/builders' serde-checker (and its builtin-modules JSON
import) into every step and workflow bundle.
Co-authored-by: Mohith Gajjela <109003762+Mohith26@users.noreply.github.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
VaguelySerious
force-pushed
the
backport/pr-4537-to-stable
branch
from
September 30, 2026 21:39
74839a4 to
e3dfd0d
Compare
Contributor
Author
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nextjs-webpack (1 failed):
🌍 Community Worlds (106 failed)redis (21 failed):
turso (85 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #4537 to
stable(backport job run).AI recommendation: This is a pure bug fix (patch changeset) to builder behavior that already exists on
stable: SWC/esbuild droppedwith { type: 'json' }, crashing Node's ESM loader withERR_IMPORT_ATTRIBUTE_MISSING, and fast discovery matched serde patterns inside string literals, wrongly bundling@workflow/builders' own serde-checker into every step and workflow bundle. The reports motivating it (#3157, #4442) come from the 4.x line, and no feature work is mixed in. Note that the discovery half will conflict:stable'spackages/builders/src/fast-discovery.tsstill uses a local regexstripCommentsandtransform-utils.tshas nostripCommentsFromSourcescanner, so that part needs manual adaptation (the import-attributes half applies as is).Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.