Repository navigation
[core] QuickJS engine reports its log position and consumes returned event pages; document who names a position #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ff3b8a1
[core] Give the QuickJS engine log-position parity and document who n…
VaguelySerious 7cd9c3e
[core] Deliver only pages to the QuickJS VM, never the created event …
VaguelySerious ebb5337
[core] Address review: mirror the node inline-delta gate, hook_create…
VaguelySerious File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflow/core': patch | ||
| --- | ||
|
|
||
| The QuickJS engine now reports its log position on writes and feeds its VM from the events a World returns on the response, matching the node:vm engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Both runtime engines follow this table" is not quite true for the
hook_createdrow: the node suspension handler sendseventCountandsinceCursoron one hook write per suspension (that delta is how a hook whose payload already arrived resolves in-process), while this PR's QuickJSdispatchPendingOpssends onlyeventCountonhook_created. Either note the QuickJS exception in the row, or add thesinceCursorask on the QuickJS side in a follow-up. The same applies to thehelpers.tscopy of the table.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(AI) Added the
sinceCursorask on the QuickJS side in ebb5337 rather than noting an exception.dispatchPendingOpstakes adeltaCursorfrom the loop and passes it assinceCursoron thehook_createdcreate when exactly one hook needs creating (the node handler'shookDeltaCursorgate); thecreateEventseam takes a delta response throughabsorbDeltaso the cursor moves with it. Pinned by a new test inquickjs-slot-report.test.ts(hook_created reaches the VM off the delta, no listing). Both table copies updated to say the ask is gated on exactly one hook, since that is the part that was imprecise for the node engine too.