Repository navigation
[DO NOT MERGE] CI dry-run: QuickJS as the default workflow VM engine #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
753c981
Add opt-in QuickJS WASM VM engine (WORKFLOW_VM=quickjs) with full eve…
TooTallNate adb3d0e
QuickJS engine: AbortController, setAttributes, terminal drain, turbo…
TooTallNate 6be76e2
QuickJS engine: hook.getConflict support, cross-run writable forwardi…
TooTallNate 9d2530e
QuickJS engine: stream framing round-trip, bound step proxies, webhoo…
TooTallNate c57127d
Apply biome fixes to QuickJS engine files
TooTallNate ff400af
Address review feedback: anchor source-map strip to end-of-input, use…
TooTallNate 5d4c578
CI: include generated QuickJS source assets in shared e2e build artif…
TooTallNate 24017cc
Fix same-token hook ordering and conflicted-hook disposal in the Quic…
TooTallNate ad80ba8
CI: run both VM engines across all frameworks and worlds; label jobs …
TooTallNate 2bd67b9
Fix stack overflow stripping inline source maps from webpack dev bund…
TooTallNate 2a082dd
e2e: poll step listings until analytics rows include attempt (optiona…
TooTallNate 0518e1c
e2e: use --withData to force storage-backed step listings for attempt…
TooTallNate 6336b47
Sort imports in QuickJS serialization files (biome organizeImports)
TooTallNate 2f3434d
QuickJS engine: resolve the run's full payload-key capability so seal…
TooTallNate 1ff0ed9
Address review: crypto/process parity, loud Intl guards, lazy engine …
TooTallNate fe96bca
QuickJS engine: implement resilient resumeHook (hookInput materializa…
TooTallNate 4506623
QuickJS engine: inline step execution via live-VM continuation loop +…
TooTallNate b232778
Address review: exclusive inline step claims, self-write requeue, in-…
TooTallNate 6aea4c5
Add world.snapshots storage interface with local, postgres, and verce…
TooTallNate 968cfa1
Address review: validate runId before filesystem paths in snapshots s…
TooTallNate ad89c02
Add threshold-based VM-memory snapshotting to the QuickJS engine (WOR…
TooTallNate c139c2a
Address review: snapshot correctness — total event ceiling, position-…
TooTallNate 6af2c2c
Make QuickJS the default workflow VM engine (WORKFLOW_VM=node opts ba…
TooTallNate 8f88b5e
Merge origin/main (post-#3048) into quickjs-vm-perf; address review t…
TooTallNate d2a115b
Merge branch 'quickjs-vm-perf' into quickjs-vm-snapshots
TooTallNate e294ed1
Merge quickjs-vm-snapshots (post-main sync) into quickjs-vm-threshold…
TooTallNate 74bd053
Merge branch 'quickjs-vm-threshold-snapshots' into quickjs-vm-default
TooTallNate 0584471
Merge remote-tracking branch 'origin/main' into quickjs-vm-snapshots
TooTallNate a5ee711
Merge branch 'quickjs-vm-snapshots' into quickjs-vm-threshold-snapshots
TooTallNate d41872a
Merge branch 'quickjs-vm-threshold-snapshots' into quickjs-vm-default
TooTallNate 374dbaa
Address review: atomic snapshot envelope, optional interface, idempot…
TooTallNate f624888
Merge branch 'quickjs-vm-snapshots' into quickjs-vm-threshold-snapshots
TooTallNate eee5695
Address review: prod-world metadata round-trip, engine-build pin, clo…
TooTallNate c671016
Merge branch 'quickjs-vm-threshold-snapshots' into quickjs-vm-default
TooTallNate a8bff02
core: quickjs engine divergence-detection and write-fencing parity
TooTallNate 8a78801
Merge quickjs-divergence-parity into quickjs-vm-default
TooTallNate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflow/core': minor | ||
| --- | ||
|
|
||
| The QuickJS WASM VM is now the default workflow engine. Set `WORKFLOW_VM=node` to opt back into the `node:vm` engine. Existing runs keep executing on the engine stamped in their `executionContext` at start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflow/core': patch | ||
| --- | ||
|
|
||
| QuickJS engine: divergence-detection and write-fencing parity with the node:vm engine. Replays now arbitrate the event log at each fixed point (orphaned events, stepName/token/resumeAt mismatches) and escalate `ReplayDivergenceError` through the existing recovery machinery instead of silently delivering wrong payloads or surfacing corruption as `USER_ERROR`; all replay-context event writes now carry the optimistic-concurrency precondition snapshot (closing the documented KNOWN GAP), with `run_failed` left unfenced to match the node engine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@workflow/core': minor | ||
| 'workflow': minor | ||
| --- | ||
|
|
||
| Add threshold-based VM-memory snapshotting to the QuickJS engine via `WORKFLOW_SNAPSHOT_THRESHOLD` (or per-run `executionContext.snapshotThreshold`). Once the configured number of events has been processed since the last snapshot, suspensions persist a compressed (and encrypted, when configured) VM snapshot through `world.snapshots`; resumptions restore the VM and replay only the delta events, with automatic fallback to full replay on any load/restore failure. `0` (default) disables snapshotting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@workflow/world': minor | ||
| '@workflow/world-local': minor | ||
| '@workflow/world-postgres': minor | ||
| '@workflow/world-vercel': minor | ||
| --- | ||
|
|
||
| Add an OPTIONAL `snapshots` storage interface (`save`/`load`/`delete` + `SnapshotMetadata`, plus `encodeSnapshotEnvelope`/`decodeSnapshotEnvelope` helpers that pack metadata and bytes into one atomically-storable blob) for VM-memory snapshotting, with implementations in world-local (single envelope file per run), world-postgres (`workflow_snapshots` table storing the envelope), and world-vercel (workflow-server `/v2/runs/:runId/snapshot` endpoints with W3C trace-context injection; delete is 404-idempotent). Inert until the runtime opts in; community World implementations that don't provide `snapshots` are unaffected (the runtime feature-detects and falls back to full replay). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.