Repository navigation
fix(code-block): match download extensions case-insensitively - #712
Merged
farnabaz merged 1 commit intoNov 4, 2026
Merged
Conversation
Contributor
|
@Manishram-ai is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code block download button looks up the file extension with
language in languageExtensionMap, which is case-sensitive and also matches keys onObject.prototype. The highlighter lowercases the language, so```Pythonis highlighted fine but downloads asfile.txt, and```constructordownloads asfile.function Object() { [native code] }.This lowercases the language before the lookup and uses
Object.hasOwn, likemarkdown.tsalready does.Type of Change
Changes Made
download-button.tsx: lowercase the language and check own keys onlyPython,JSONandTypeScript, and forconstructor,toStringand__proto__falling back to.txtTesting
The 6 new tests fail on
mainand pass with this change. The fullstreamdownsuite passes (1,316 tests), and Biome is clean on the changed files.Checklist
pnpm changeset)Changeset