Repository navigation
Add HTTP Host pinning shorthand to sandbox network policies - #352
Draft
roboeve[bot] wants to merge 1 commit into
Draft
roboeve[bot] wants to merge 1 commit into
roboeve[bot] wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow SDK callers to pin an allowed domain's outgoing HTTP Host header with
{ httpOnly: true }, without writing a transform manually.Why
A domain allow-list alone does not pin the HTTP Host header. Callers can already express the necessary transform, but the security-sensitive configuration is easy to omit.
Approach
Add
httpOnly: trueas a mutually exclusive SDK rule action. The shared network-policy serializer expands it to{ transform: [{ headers: { Host: domain } }] }before validating and sending the API request, so create, fork, and policy updates use the existing wire behavior. Reject wildcard domains because they cannot be pinned to one exact Host value. The original policy is not mutated. The shorthand applies to matching requests, following normal rule ordering.Validation
pnpm --filter @vercel/sandbox exec vitest run src/utils/network-policy.test.ts(36 passed)pnpm --filter @vercel/sandbox test(346 passed, 81 skipped before the final extra edge-case test)pnpm --filter @vercel/sandbox typecheck(passed)pnpm --filter @vercel/sandbox build(passed)git diff --check(passed)