docs: fix onRequestError error type example#94518
Merged
icyJoseph merged 2 commits intoJun 8, 2026
Merged
Conversation
icyJoseph
reviewed
Jun 8, 2026
icyJoseph
approved these changes
Jun 8, 2026
Member
|
Nice, once again thanks. We require signed commits. Do you mind rewriting the commits on this branch so that they are signed? |
Contributor
Author
|
Oh sure |
danyalahmed1995
force-pushed
the
docs/on-request-error-unknown
branch
from
30ccd11 to
ee6bb8b
Compare
Contributor
Author
|
Done, I rewrote the branch with signed commits. |
danyalahmed1995
force-pushed
the
docs/on-request-error-unknown
branch
from
ee6bb8b to
e2264c8
Compare
icyJoseph
approved these changes
Jun 8, 2026
Contributor
Stats skippedCommit: e2264c8 |
Contributor
Tests PassedCommit: e2264c8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94499
Summary
The
Instrumentation.onRequestErrortype currently exposes the error parameter asunknown, but the docs described it asError & { digest: string }and the example accessederr.messagedirectly.This updates the docs/example to match the current type and narrows the caught value before reading
message.Tests:
git diff --check