Repository navigation
Conversation
ctate
commented
Nov 6, 2026
ctate
commented
- Move the packages and docs site to TypeScript 7
- Replace tsup's dts with tsc declarations, and ESLint with oxlint in the docs site and UI package
- Keep the Svelte packages and examples on TypeScript 5, whose tooling needs its API
- Move the packages and docs site to TypeScript 7 - Replace tsup's dts with tsc declarations, and ESLint with oxlint in the docs site and UI package - Keep the Svelte packages and examples on TypeScript 5, whose tooling needs its API
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
- Watch src in tsup dev so type-only edits re-emit declarations - Give the Solid providers explicit return types, so their declarations parse in TypeScript before 5.3
lahfir
left a comment
lahfir
left a comment
There was a problem hiding this comment.
looks good to me. two things:
| "start": "next start", | ||
| "test:routes": "node scripts/test-routes.mjs", | ||
| "lint": "eslint --max-warnings 0", | ||
| "lint": "oxlint", |
There was a problem hiding this comment.
before, only-warn + --max-warnings 0 meant any lint hit failed CI. oxlint exits 0 on warnings, so the warn rules here (exhaustive-deps, the nextjs/* ones) now pass CI. oxlint --deny-warnings brings that back, same for packages/ui. both are at 0 diagnostics today so nothing breaks.
| import { isAbsolute, join } from "node:path"; | ||
|
|
||
| export async function emitTypes(packageDir, { bundle } = {}) { | ||
| execFileSync("tsc", ["-p", "tsconfig.build.json"], { |
There was a problem hiding this comment.
if tsc fails here in watch mode, the throw skips tsup's startWatcher(). a type error at startup makes tsup --watch src exit 1. in next/tanstack-start it quietly stops the client config's watcher while the server one keeps going. and in the bundled packages clean: true no longer keeps .d.ts, so dist/index.d.ts disappears until the error is fixed. what if we only throw when not watching, and still run the rolldown step when tsc fails?
