Wrap long gateway status URLs on narrow terminals - #757
Draft
adi-IL wants to merge 1 commit into
Draft
Conversation
Raise the static status activity row cap and keep a head continuation on the last truncated row so mid-message URLs are not collapsed behind a leading ellipsis. Fixes vercel-labs#618.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #618. Narrow terminals were collapsing long gateway status URLs behind a leading
...on the last activity row instead of wrapping them.Root cause: warning/danger status paint keeps a trailing recovery slice on the last row (
...+ suffix only), and the activity band was capped at 3 rows. That skipped the mid-message URL head once the row budget ran out.Changes
max_static_status_activity_rowsfrom 3 to 8 so typical access-denied messages can wrap fully....+ recovery suffix so URL text is not jumped over.Verification
No Zig 0.16 in this environment, so I could not run
zig build testor./zig-out/bin/fxlocally. Full CI on this commit is the deterministic proof. Please smoke the access-denied status on a ~48-col terminal after CI is green.I do not have label rights; please apply
type: bug.Checklist
./zig-out/bin/fxsmoke (needs Zig here or maintainer check)