Allow the dynamic PDF-name cache to be cleared and bounded - #730
Open
softvisionfd wants to merge 1 commit into
Open
Allow the dynamic PDF-name cache to be cleared and bounded#730softvisionfd wants to merge 1 commit into
softvisionfd wants to merge 1 commit into
Conversation
ASAtom keeps a process-wide cache of PDF names that are not one of the predefined constants. It never evicts, so a long-running process that validates documents with many unique names keeps accumulating them for its whole lifetime, with no way to reclaim the memory. Add ASAtom.clearCache() to drop the accumulated dynamic names (the predefined constants are untouched), and an optional upper bound via setMaxCachedNames beyond which new names are returned uncached. Atom equality is by value, so an uncached atom behaves identically to a cached one; no code compares atoms by identity except against the predefined constants, which are unaffected. Default is unbounded with no automatic clearing, so behaviour is unchanged unless a caller opts in.
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ASAtomkeeps a process-wide cache of PDF names that are not one of the predefined constants. It neverevicts, so a long-running process that validates documents with many unique names keeps accumulating them
for its whole lifetime, with no way to reclaim the memory.
Changes
ASAtom.clearCache()drops the accumulated dynamic names (the predefined name constants are untouched).A long-running process that validates untrusted documents can call this between jobs to release names
accumulated from earlier documents.
ASAtom.setMaxCachedNames(int)/getMaxCachedNames()set an optional upper bound; once the cache holdsthat many names, new names are returned uncached.
Atom equality is by value (
equals/hashCode), so an uncached atom behaves identically to a cached one;no code compares atoms by identity except against the predefined constants, which are unaffected.
Backward compatibility
Default is unbounded with no automatic clearing, so behaviour is unchanged unless a caller opts in. Java 8
compatible, and all existing parser tests pass.