Skip to content

fix: keep Jira sidebar collapse controls accessible - #2

Merged
vatsa31 merged 1 commit into
masterfrom
fix/jira-sidebar-collapse-controls
Sep 12, 2026
Merged

vatsa31 merged 1 commit into
masterfrom
fix/jira-sidebar-collapse-controls

Conversation

@vatsa31

@vatsa31 vatsa31 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Problem and fix

Collapsing the Jira resource allocated one row, but the renderer used that row for a divider and returned before drawing the expand control. Render the header in that row so the section can be reopened, including with existing collapsed preferences.

An expanded resource could also cover the sidebar's bottom « toggle with its scrollbar or item hit regions. Reserve the footer row when a resource is present so the visible toggle receives clicks. Clamp the refresh hit region to the header width.

Validation

  • Client-shell suite: 204 passed, 0 failed, 1 ignored, including three new regression tests for repeated collapse/reopen through mouse events, whole-sidebar toggling in both resource states, and short-layout footer separation.
  • Changed Rust files pass rustfmt --check; git diff --check passes.
  • just check could not run because just is not installed; cargo-nextest is also unavailable. Existing unused-import/dead-code warnings remain.
  • Original bugs were reported on an Apple Silicon office Mac with mock and real Jira data. The fixes were tested on Linux; no additional Mac test was performed.

No Jira plugin changes or independent section resizing are included.

@vatsa31
vatsa31 merged commit f6786fb into master Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant