Repository navigation
fix: keep Jira sidebar collapse controls accessible - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
Collapsing the Jira resource allocated one row, but the renderer used that row for a divider and returned before drawing the expand control. Render the header in that row so the section can be reopened, including with existing collapsed preferences.
An expanded resource could also cover the sidebar's bottom
«toggle with its scrollbar or item hit regions. Reserve the footer row when a resource is present so the visible toggle receives clicks. Clamp the refresh hit region to the header width.Validation
rustfmt --check;git diff --checkpasses.just checkcould not run becausejustis not installed;cargo-nextestis also unavailable. Existing unused-import/dead-code warnings remain.No Jira plugin changes or independent section resizing are included.