docs: note refreshAll after TreeData mutations #19327 - #25606
Merged
mcollovati merged 3 commits intoSep 10, 2026
Conversation
mcollovati
added
the
Contribution
mcollovati
requested changes
Sep 10, 2026
Co-authored-by: Marco Collovati <mcollovati@gmail.com>
mcollovati
previously approved these changes
Sep 10, 2026
mcollovati
enabled auto-merge
September 10, 2026 09:33
mcollovati
approved these changes
Sep 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 10, 2026
vaadin-bot
added a commit
that referenced
this pull request
Sep 10, 2026
…5.3) (#25646) This PR cherry-picks changes from the original PR #25606 to branch 25.3. --- #### Original PR description > Fixes #19327 > > **DX/docs** · flow-data · apps that mutate TreeData under TreeGrid > > setParent and moveAfterSibling already say to call > TreeDataProvider.refreshAll(). addItem, removeItem and the other > mutating methods did not, so drag-and-drop samples that only update > TreeData look like a no-op. > > I added the same refreshAll note on the class and on every mutating > method. > > **Risks:** > - javadoc only > > - Note refreshAll on TreeData and on add/remove/clear/addItems > Co-authored-by: Abdullah <89297042+AzazelSensei@users.noreply.github.com> Co-authored-by: Marco Collovati <mcollovati@gmail.com> Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19327
DX/docs · flow-data · apps that mutate TreeData under TreeGrid
setParent and moveAfterSibling already say to call
TreeDataProvider.refreshAll(). addItem, removeItem and the other
mutating methods did not, so drag-and-drop samples that only update
TreeData look like a no-op.
I added the same refreshAll note on the class and on every mutating
method.
Risks:
javadoc only
Note refreshAll on TreeData and on add/remove/clear/addItems