feat: Improve AppShellConfigurator annotation error details (vaadin/hilla#231) - #25390
Merged
Merged
Conversation
Name the annotation and the class it was found on. If an AppShellConfigurator already exists, tell the user to move the annotations there.
|
|
|
|
mcollovati
added
the
Contribution
mshabarov
changed the title
mshabarov
previously approved these changes
Aug 31, 2026
mshabarov
enabled auto-merge
September 1, 2026 06:25
Contributor
|
@AzazelSensei thanks for the contribution! Ready for merging after validation ends. |
Artur-
disabled auto-merge
September 2, 2026 05:26
Artur-
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/hilla#231
I made the error name the annotation and the class it was found on. If an AppShellConfigurator already exists, it tells you to move the annotations there instead of creating a new class.