fix(wasi): cp attribute preservation and reflink handling - #13685
Conversation
|
GNU testsuite comparison: |
6dc0718 to
c0a4356
Compare
|
i am surprised that you didn't enable more tests in test_cp.rs ?! |
|
I avoided adding more coverage as it makes rebasing all the changes back in the original branch harder. As soon as the rest of improvements are merged into main, I will gradually try to fix the tests being skipped for WASI and, if possible, increase coverage as well. |
|
I am sorry but it is a requirement. I don't land changes without tests |
|
Priority given to #13804. I have put this one to draft |
c0a4356 to
f909468
Compare
0fbb538 to
03e405b
Compare
|
Binary size comparison: |
|
i am not a fan of this long list of deactivation of tests for wasi :/ |
I agree. Let me finish all the pending PRs to get WASI Preview 2 testing enabled. I will leave the test for |
cp treats ENOSYS like EOPNOTSUPP when skipping optional attribute preservation (WASI has no chmod/chown at all), reads timestamps via Metadata::accessed/modified instead of the filetime crate (which panics there), and only errors out of --reflink when explicitly requested rather than whenever it isn't Never.
03e405b to
51f6f9b
Compare
cp treats ENOSYS like EOPNOTSUPP when skipping optional attribute preservation (WASI has no chmod/chown at all), reads timestamps via Metadata::accessed/modified instead of the filetime crate (which panics there), and only errors out of --reflink when explicitly requested rather than whenever it isn't Never.
Rebased onto main now that #13804 covers WASI symlink support separately.