Repository navigation
uucore: for fs use real inode dev stat on wasi - #13684
eduardomourar wants to merge 1 commit into
Conversation
Merging this PR will regress 2 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
afbd6fb to
7425df9
Compare
|
GNU testsuite comparison: |
7425df9 to
ab6642b
Compare
3d8f91e to
2d8d677
Compare
d880271 to
d5437e3
Compare
|
@sylvestre, this one is ready (now with proper testing in place). |
2dcd55b to
106a29b
Compare
106a29b to
3995f34
Compare
16bc926 to
d7de947
Compare
|
Thanks, this looks much better: there's one rustix impl shared by unix and wasi now, the target-first early return is still there, and the tests run on wasi too. One nit left: the comment in fsext/mod.rs:142 can just be |
d7de947 to
d0fad40
Compare
|
Done. Added a step to wasi.yml in order to run the unit tests for |
d0fad40 to
a7880bd
Compare
a7880bd to
be1501f
Compare
FileInformation previously fell back to a std::fs::Metadata-based heuristic (comparing file type and size) on WASI, since it lacked access to nix::sys::stat. Switch it to rustix::fs::Stat, the same backing type used on Unix, giving WASI real inode/device identity, nlink, and equality checks instead of an approximation. Also add WASI implementations of are_hardlinks_to_same_file and are_hardlinks_or_one_way_symlink_to_same_file via rustix::fs::stat/ lstat, since std::os::unix::fs::MetadataExt is unavailable there.