feat: Add Gitea git operations and user endpoints

[jaysomani]

• Implement updateCommitStatus for CI/CD status updates
• Implement generateCloneCommand for branch/commit/tag cloning
• Implement getUser to fetch user information
• Implement createTag to create repository tags
• Mark getInstallationRepository as not applicable (throws exception)
• Add comprehensive tests for all methods
• Include error cases and try/finally cleanup

Summary by CodeRabbit

• New Features

  • Gitea integration now supports user profile retrieval, commit status updates, and tag creation.
  • Enhanced repository cloning with support for multiple checkout methods including branches, commits, and tags.

• Tests

  • Added comprehensive test coverage for new Gitea operations, including error handling scenarios.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3ab90e8-79d6-4b6d-b7b8-99aa23f1a504

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The changes implement five new public methods in the Gitea VCS adapter class to support version control operations: user information retrieval, repository tag creation, commit status updates, clone command generation with sparse checkout support, and handling of installation repository requests (which are not applicable to Gitea). Corresponding test coverage is added for all new methods, including multiple scenarios for clone commands across branch, commit, and tag references, error handling cases, and user and tag operations.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.93% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: implementing multiple Gitea git operations (updateCommitStatus, generateCloneCommand, createTag) and user endpoints (getUser, getInstallationRepository).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting to generate walkthrough in a markdown collapsible section.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6b99991ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

tests/VCS/Adapter/GiteaTest.php (1)

466-467: Remove tautological assertion in testUpdateCommitStatus.

assertTrue(true) does not validate behavior; rely on no-exception flow (or add a concrete status verification assertion if available).

Suggested patch

-            // If we get here without exception, test passes
-            $this->assertTrue(true);
+            // No exception means status update call succeeded.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/VCS/Adapter/GiteaTest.php` around lines 466 - 467, Remove the
tautological assertion in testUpdateCommitStatus: locate the test method
testUpdateCommitStatus in tests/VCS/Adapter/GiteaTest.php and delete the line
containing $this->assertTrue(true); either relying on the test passing by not
throwing an exception or replacing it with a meaningful assertion that verifies
the commit status (for example, assertEquals/assertSame against the updated
status returned by the method under test or by calling the adapter's status
retrieval method if available).

src/VCS/Adapter/Git/Gitea.php (1)

138-140: Optional cleanup: mark the interface-required parameter as intentionally unused.

Line 138 keeps $repositoryName only for signature compatibility; consider renaming to $_repositoryName to silence PHPMD intentfully.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/VCS/Adapter/Git/Gitea.php` around lines 138 - 140, The
getInstallationRepository method still declares an unused parameter
$repositoryName for interface compatibility; rename it to $_repositoryName (or
prefix with underscore) in the method signature of getInstallationRepository to
intentionally mark it unused and silence PHPMD, keeping the method body
(throwing the Exception) unchanged so compatibility is preserved.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/VCS/Adapter/Git/Gitea.php`:
- Line 383: The user name is inserted directly into the path at the $url
assignment in Gitea.php which can break URLs with special characters; update the
$url construction to path-encode the username (use rawurlencode on $username)
before interpolation so the segment is safe, ensuring any references to $url in
methods like the Gitea API request callers remain unchanged.
- Around line 560-597: The git remote add origin command currently injects raw
$cloneUrl into the shell command (in the $commands array) which is unsafe and
must be wrapped with escapeshellarg($cloneUrl) before concatenation; also add a
default branch in the switch on $versionType to explicitly reject unsupported
values (throw an InvalidArgumentException or RuntimeException mentioning
$versionType and the allowed constants CLONE_TYPE_BRANCH, CLONE_TYPE_COMMIT,
CLONE_TYPE_TAG) so unknown clone types no longer silently do nothing; update the
entry that builds "git remote add origin {$cloneUrl}" to use the escaped value
and add a default: case to the switch that raises an exception.

---

Nitpick comments:
In `@src/VCS/Adapter/Git/Gitea.php`:
- Around line 138-140: The getInstallationRepository method still declares an
unused parameter $repositoryName for interface compatibility; rename it to
$_repositoryName (or prefix with underscore) in the method signature of
getInstallationRepository to intentionally mark it unused and silence PHPMD,
keeping the method body (throwing the Exception) unchanged so compatibility is
preserved.

In `@tests/VCS/Adapter/GiteaTest.php`:
- Around line 466-467: Remove the tautological assertion in
testUpdateCommitStatus: locate the test method testUpdateCommitStatus in
tests/VCS/Adapter/GiteaTest.php and delete the line containing
$this->assertTrue(true); either relying on the test passing by not throwing an
exception or replacing it with a meaningful assertion that verifies the commit
status (for example, assertEquals/assertSame against the updated status returned
by the method under test or by calling the adapter's status retrieval method if
available).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f0ec1072-cc08-4cbe-ad53-ae41e2289ca9

📥 Commits

Reviewing files that changed from the base of the PR and between 5769679 and d6b9999.

📒 Files selected for processing (2)

• src/VCS/Adapter/Git/Gitea.php
• tests/VCS/Adapter/GiteaTest.php

[greptile-apps]

Greptile Summary

This PR implements four previously stubbed-out Gitea adapter methods — getUser, updateCommitStatus, createTag, and generateCloneCommand — along with integration tests for each. The implementations are generally well-structured and follow existing patterns in the codebase, but there is one critical correctness issue that must be addressed before merging.

Key changes and issues:

• Critical — generateCloneCommand parameter order mismatch: The Gitea implementation reorders parameters to ($owner, $repositoryName, $directory, $rootDirectory, $version, $versionType, $accessToken = ''), which differs from the abstract Adapter.php interface ($owner, $repositoryName, $version, $versionType, $directory, $rootDirectory). Because all parameters are string, PHP will not throw a fatal error, but any polymorphic caller following the abstract interface will silently pass $version as $directory, $versionType as $rootDirectory, etc., producing a completely wrong shell command at runtime. The tests were also written against the new (incorrect) order, so they won't catch this regression.

• Security — unescaped subshell output in tag clone command: The CLONE_TYPE_TAG branch interpolates the output of a $(git ls-remote | awk) subshell directly into the outer shell command. If a malicious remote exposes a tag with special shell characters, this could lead to command injection.

• getUser, updateCommitStatus, and createTag are well implemented and consistent with the patterns used elsewhere in the file.

• The getInstallationRepository improvement (better error message + documentation) is a nice addition.

• Tests follow the try/finally cleanup pattern used in the rest of the test suite.

Confidence Score: 2/5

• Not safe to merge — the generateCloneCommand parameter order breaks the abstract interface contract and will cause silent runtime failures in polymorphic usage.
• The parameter order bug in generateCloneCommand is a critical correctness issue: all parameters are string-typed so PHP will not catch the mismatch, but callers following the Adapter interface will silently receive a completely wrong shell command. This must be fixed (and the tests updated) before the PR is safe to merge.
• src/VCS/Adapter/Git/Gitea.php — specifically the generateCloneCommand signature and the CLONE_TYPE_TAG subshell command.

Important Files Changed

Filename	Overview
src/VCS/Adapter/Git/Gitea.php	Implements getUser, updateCommitStatus, createTag, and generateCloneCommand. The generateCloneCommand method has a critical parameter order mismatch vs. the abstract Adapter interface, which will silently produce incorrect behaviour when the adapter is used polymorphically. The tag clone case also interpolates an unescaped subshell output into a shell command.
tests/VCS/Adapter/GiteaTest.php	Adds integration tests for all new methods. Tests for generateCloneCommand use the new (incorrect) Gitea-specific parameter order rather than the abstract interface order, meaning they will need to be updated when the signature is fixed.

_{Last reviewed commit: "Merge branch 'utopia..."}