Conversation
Headers can now be arrays (after recent changes allowing array headers). The getSize() method was attempting to directly implode headers, causing a warning when a header value was an array. This fix properly handles both string and array header values by joining array values with commas (standard HTTP header format) before calculating the request size. Added test case to verify the fix works correctly with array headers.
feat: remove validators and use utopia validators lib
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (66)
WalkthroughThis pull request performs a major architectural refactor upgrading the framework from PHP 8.0/8.1 to 8.2, integrating a dependency injection (DI) container pattern, and relocating validators to a separate namespace. The Http class API is modified to accept a Container parameter and use container-based resource management instead of static context-based resources. All validator classes in Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Key ChangesArchitecture & API:
Validator System:
Adapter Implementations:
Dependencies:
Testing:
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Release Notes
Breaking Changes
Http::setResource()to container-based approachNew Features
Documentation
Chores