test: add unit tests for Firecracker hypervisor#769
Open
sahilforkshere wants to merge 1 commit into
Open
Conversation
Add unit tests covering Firecracker.BuildExecCmd (generated launch command and JSON config) and its helper methods. Fixes: urunc-dev#96 Signed-off-by: Sahil <paalsahil04@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the Firecracker hypervisor in
pkg/unikontainers/hypervisors/firecracker.go, which previously had notest coverage. The tests cover
BuildExecCmd(the generated launchcommand and the JSON config it produces) and the smaller helper methods
(
Path,UsesKVM,Ok,PreExec,SupportsSharedfs).This is a step toward improving overall unit test coverage as requested
in #96.
Related issues
How was this tested?
Ran locally:
go test ./pkg/unikontainers/hypervisors/— all tests passgo vet ./pkg/unikontainers/hypervisors/— cleangofmt -l— no formatting issuesNo production code was changed; this PR only adds a new test file.
LLM Usage
I used Claude as a development assistant while writing these tests. I determined the test coverage, reviewed and edited the code, and verified that the implementation builds and passes all tests locally.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).