Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Todo:
|
cbuto
left a comment
There was a problem hiding this comment.
I started going through 1.13 docs and noted somethings I found. Some of it might apply to other versions as well.
I still need to go through more but its a lot 😄
spaces_versioned_docs/version-1.13/howtos/workload-id/backup-restore-config.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Shared backups | ||
|
|
||
| As of Spaces `v.12.0`, this feature is enabled by default. |
There was a problem hiding this comment.
we can prob drop this reference to 1.12 and just state its enabled by default
| --- | ||
|
|
||
| :::important | ||
| This feature is in preview. Starting in Spaces `v1.8.0` and later, you must |
There was a problem hiding this comment.
we can drop the references to 1.8
| } | ||
| ``` | ||
|
|
||
| For more information about workload identities, review the [Workload-identity |
There was a problem hiding this comment.
definitely some overlap with the workload ID doc for billing here. In the future, we should probably combine or maybe even remove https://docs.upbound.io/manuals/spaces/howtos/self-hosted/workload-id/billing-config/
|
|
||
| Spaces supports the three [preceding minor versions][preceding-minor-versions] from the last supported minor version. example, if the last supported minor version is `1.14`, minor versions `1.13` and `1.12` are also supported. Versions older than the three most recent minor versions aren't supported. Only supported Crossplane versions are valid specifications for new control planes. | ||
|
|
||
| Current Crossplane version support by Spaces version: |
There was a problem hiding this comment.
oh man this is out of date lol, maybe we just drop this in all docs versions
spaces_versioned_docs/version-1.13/howtos/mcp-connector-guide.md
Outdated
Show resolved
Hide resolved
cbuto
left a comment
There was a problem hiding this comment.
I still have a lot to go through but this is looking really great @tr0njavolta!
| ::: | ||
|
|
||
| :::note | ||
| Control Plane Topologies is not yet available for Cloud Spaces. This feature is currently available for Connected and Disconnected (Self-Hosted) Spaces only. |
There was a problem hiding this comment.
we can remove this from cloud spaces docs
| In this tutorial, you learn how to configure a Kubernetes app cluster to communicate with a control plane in an Upbound Space. | ||
|
|
||
|
|
||
| The [control plane connector][control-plane-connector] bridges your Kubernetes application clusters---running outside of Upbound--to your control planes running in Upbound. This allows you to interact with your control plane's API right from the app cluster. The claim APIs you define via `CompositeResourceDefinitions` are available alongside Kubernetes workload APIs like `Pod`. In effect, control plane connector provides the same experience as a locally installed Crossplane. |
There was a problem hiding this comment.
this doc and cloud-spaces-docs/howtos/ctp-connector.md both cover MCP connector but a bit different 🤔. we could probably combine them or just remove one?
| @@ -0,0 +1,412 @@ | |||
| --- | |||
| title: Disaster Recovery | |||
There was a problem hiding this comment.
organizationally, disaster recovery should be a top level topic and under should be SpaceBackups and SharedBackups
| To enable it on versions earlier than `v1.14.0`, set features.alpha.spaceBackup.enabled=true when you install Spaces. | ||
|
|
||
| ```bash | ||
| up space init --token-file="${SPACES_TOKEN_PATH}" "v${SPACES_VERSION}" \ |
There was a problem hiding this comment.
one thought for future us:
most users are likely not using up space init when managing Spaces, so having docs focus more on configuration of an existing Space vs full end to end install would make things less complicated and more concise. Not something we should tackle now but i noticed it going through a lot of these docs.
| @@ -0,0 +1,164 @@ | |||
| --- | |||
There was a problem hiding this comment.
I can't find a good spot to comment this but having Connect as a high level topic might be confusing.
When we discuss connect in the context of Spaces, we typically are referencing:
https://docs-git-versioned-spaces-upboundio.vercel.app/self-hosted-spaces/howtos/attach-detach/
I'm unsure if api connector/mcp connector don't necessarily belong with Query API.
Connect as a high level topic would be:
- connecting a Space
- Query API
The self-hostee MCP connector docs also still reference cloud, which we can remove.
Description
#1029
This PR attempts to address the issue of Spaces versioning. This creates a multi-site instance for the Spaces docs to avoid confusion with UXP versioning.
The multi-site implementation is in line with what Docusaurus recommends for distinct sets docs (UXP vs Spaces in this case) https://docusaurus.io/docs/docs-multi-instance
Type of change
Checklist
make lintlocally (or will fix Vale suggestions in review)Additional notes