chore: pin systems to UnstoppableMango/nix-systems - #86
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe flake now uses ChangesSystems flake integration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change restricts Hercules CI builds to the available x86_64-linux agents without removing local Darwin outputs. The locked dependency and stated evaluated behavior support merging with no current merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to flake input pinning and module import, with no detected wiring or evaluation issues in the updated flake.nix/flake.lock diff.
Pull request overview
Pins the flake’s systems input to UnstoppableMango/nix-systems and imports its flake module so Hercules CI only targets the intended CI system set (while still exposing all flake outputs for all supported systems).
Changes:
- Switch
inputs.systemsfromnix-systems/triplettoUnstoppableMango/nix-systems. - Import
systems.flakeModuleto setherculesCI.ciSystemsvia the pinned systems input. - Update
flake.lockto the new input source and revision.
File summaries
| File | Description |
|---|---|
| flake.nix | Repoints the systems input and imports systems.flakeModule to drive CI system selection. |
| flake.lock | Updates the lock entry for systems to UnstoppableMango/nix-systems with the new pinned rev/hash. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The Hercules CI agents are x86_64-linux only, so the darwin outputs this flake offers queue against an agent that does not exist and the job never schedules. The pin's flake module sets herculesCI.ciSystems, which restricts what CI builds without changing what the flake offers locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Pull request was closed
6e1e42d to
cd38f34
Compare
Part of a fleet-wide change. The Hercules CI agents are
x86_64-linuxonly, so the darwin outputs this flake offers queue against an agent that does not exist and the job never schedules.UnstoppableMango/nix-systemscarries both the system list and the CI subset. Its flake module setsherculesCI.ciSystemsand nothing else, sosystems = import inputs.systems;stays and the flake still offers every system it did before — only what CI builds changes.Adding an
aarch64-linuxagent later is one commit in the pin plus a lockfile refresh here.Verified on this repo:
nix eval .#herculesCI.ciSystemsis[ "x86_64-linux" ], andnix flake show --all-systemsstill lists the darwin outputs.🤖 Generated with Claude Code
Summary by CodeRabbit