Skip to content

chore: pin systems to UnstoppableMango/nix-systems - #86

Closed
UnstoppableMango wants to merge 1 commit into
mainfrom
chore/systems-pin
Closed

chore: pin systems to UnstoppableMango/nix-systems#86
UnstoppableMango wants to merge 1 commit into
mainfrom
chore/systems-pin

Conversation

@UnstoppableMango

@UnstoppableMango UnstoppableMango commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Part of a fleet-wide change. The Hercules CI agents are x86_64-linux only, so the darwin outputs this flake offers queue against an agent that does not exist and the job never schedules.

UnstoppableMango/nix-systems carries both the system list and the CI subset. Its flake module sets herculesCI.ciSystems and nothing else, so systems = import inputs.systems; stays and the flake still offers every system it did before — only what CI builds changes.

Adding an aarch64-linux agent later is one commit in the pin plus a lockfile refresh here.

Verified on this repo: nix eval .#herculesCI.ciSystems is [ "x86_64-linux" ], and nix flake show --all-systems still lists the darwin outputs.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration
    • Updated system configuration sources.
    • Added support for loading system-related flake modules during project configuration.

Copilot AI lite review requested due to automatic review settings September 10, 2026 03:35
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: aee3d26e-bb5e-4ec2-9be0-77537b32dee6

📥 Commits

Reviewing files that changed from the base of the PR and between a7b9659 and 6e1e42d.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • flake.nix

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The flake now uses github:UnstoppableMango/nix-systems and imports systems.flakeModule through flake-parts.

Changes

Systems flake integration

Layer / File(s) Summary
Systems input and module wiring
flake.nix
The systems input uses the new repository. The flake-parts imports include systems.flakeModule.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6e1e4

This change restricts Hercules CI builds to the available x86_64-linux agents without removing local Darwin outputs. The locked dependency and stated evaluated behavior support merging with no current merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: pinning the systems input to UnstoppableMango/nix-systems.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/systems-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped to flake input pinning and module import, with no detected wiring or evaluation issues in the updated flake.nix/flake.lock diff.

Pull request overview

Pins the flake’s systems input to UnstoppableMango/nix-systems and imports its flake module so Hercules CI only targets the intended CI system set (while still exposing all flake outputs for all supported systems).

Changes:

  • Switch inputs.systems from nix-systems/triplet to UnstoppableMango/nix-systems.
  • Import systems.flakeModule to set herculesCI.ciSystems via the pinned systems input.
  • Update flake.lock to the new input source and revision.
File summaries
File Description
flake.nix Repoints the systems input and imports systems.flakeModule to drive CI system selection.
flake.lock Updates the lock entry for systems to UnstoppableMango/nix-systems with the new pinned rev/hash.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@UnstoppableMango
UnstoppableMango enabled auto-merge (squash) September 10, 2026 04:47
The Hercules CI agents are x86_64-linux only, so the darwin outputs this
flake offers queue against an agent that does not exist and the job never
schedules. The pin's flake module sets herculesCI.ciSystems, which restricts
what CI builds without changing what the flake offers locally.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
auto-merge was automatically disabled September 10, 2026 05:29

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants