feat(pkgs): add claude-desktop-fhs package for MCP servers and Cowork support - #76
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe change adds a ChangesClaude Desktop FHS package
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This adds a registered FHS Claude Desktop package with MCP, Cowork, and OVMF compatibility support. No concrete merge-blocking correctness, security, or runtime risk is currently identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟡 Changes recommended
pkgs/default.nix currently references unfreePackages inside its own non-recursive definition, which will fail evaluation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new unfree package variant, claude-desktop-fhs, to run Claude Desktop inside an FHS environment so spawned MCP servers and Cowork’s VM tooling can find expected filesystem paths and common runtimes.
Changes:
- Register a new
claude-desktop-fhsderivation underunfreePackagesinpkgs/default.nix. - Introduce
pkgs/claude-desktop/fhs.nix, wrappingclaude-desktopwithbuildFHSEnvand adding required runtime tools and OVMF compatibility links. - Update the generated README package list and package-count badge to include the new package.
File summaries
| File | Description |
|---|---|
| README.md | Adds claude-desktop-fhs to the generated packages table and updates the package-count badge. |
| pkgs/default.nix | Wires claude-desktop-fhs into unfreePackages so it’s exposed via legacyPackages/overlay. |
| pkgs/claude-desktop/fhs.nix | New FHS wrapper derivation for Claude Desktop with additional runtime dependencies and OVMF path compatibility. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
0a148e5 to
e5da216
Compare
e5da216 to
b022c43
Compare
b022c43 to
26b7c85
Compare
Stack created with GitHub Stacks CLI • Give Feedback 💬
Summary by CodeRabbit
New Features
claude-desktop-fhspackage, providing Claude Desktop with support for MCP dependencies, Docker tooling, virtualization, and required firmware.Documentation