Skip to content

feat(pkgs): add claude-desktop-fhs package for MCP servers and Cowork support - #76

Merged
UnstoppableMango merged 1 commit into
mainfrom
claude-desktop-fhs
Sep 7, 2026
Merged

UnstoppableMango merged 1 commit into
mainfrom
claude-desktop-fhs

Conversation

@UnstoppableMango

@UnstoppableMango UnstoppableMango commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLIGive Feedback 💬

Summary by CodeRabbit

  • New Features

    • Added the claude-desktop-fhs package, providing Claude Desktop with support for MCP dependencies, Docker tooling, virtualization, and required firmware.
    • Added desktop integration, including an application launcher and icons.
    • Added support for the host configuration requirements needed for KVM and vhost-vsock functionality.
  • Documentation

    • Updated package listings and the package count in the README.

Copilot AI lite review requested due to automatic review settings September 7, 2026 18:17
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 405e039b-035e-42fb-8f9d-b920800e7e1c

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc1780 and 0a148e5.

📒 Files selected for processing (3)
  • README.md
  • pkgs/claude-desktop/fhs.nix
  • pkgs/default.nix

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The change adds a claude-desktop-fhs package with OVMF compatibility, MCP and virtualization dependencies, desktop integration, package registry wiring, and README documentation.

Changes

Claude Desktop FHS package

Layer / File(s) Summary
FHS and OVMF compatibility
pkgs/claude-desktop/fhs.nix
Defines the FHS environment and validates architecture-specific OVMF firmware and variable-store paths.
Runtime wrapper and desktop integration
pkgs/claude-desktop/fhs.nix
Wraps Claude Desktop with MCP, Docker, virtualization, firmware, desktop entry, and icon support. The metadata documents host requirements.
Package registration and documentation
pkgs/default.nix, README.md
Registers claude-desktop-fhs as an unfree package and adds it to the package table and count badge.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 26b7c

This adds a registered FHS Claude Desktop package with MCP, Cowork, and OVMF compatibility support. No concrete merge-blocking correctness, security, or runtime risk is currently identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the claude-desktop-fhs package for MCP server and Cowork support.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude-desktop-fhs

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

pkgs/default.nix currently references unfreePackages inside its own non-recursive definition, which will fail evaluation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a new unfree package variant, claude-desktop-fhs, to run Claude Desktop inside an FHS environment so spawned MCP servers and Cowork’s VM tooling can find expected filesystem paths and common runtimes.

Changes:

  • Register a new claude-desktop-fhs derivation under unfreePackages in pkgs/default.nix.
  • Introduce pkgs/claude-desktop/fhs.nix, wrapping claude-desktop with buildFHSEnv and adding required runtime tools and OVMF compatibility links.
  • Update the generated README package list and package-count badge to include the new package.
File summaries
File Description
README.md Adds claude-desktop-fhs to the generated packages table and updates the package-count badge.
pkgs/default.nix Wires claude-desktop-fhs into unfreePackages so it’s exposed via legacyPackages/overlay.
pkgs/claude-desktop/fhs.nix New FHS wrapper derivation for Claude Desktop with additional runtime dependencies and OVMF path compatibility.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkgs/default.nix
Base automatically changed from claude-desktop to main September 7, 2026 18:46
@UnstoppableMango
UnstoppableMango merged commit 5d499be into main Sep 7, 2026
6 of 7 checks passed
@UnstoppableMango
UnstoppableMango deleted the claude-desktop-fhs branch September 7, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants