No allow import from derivation - #15
Conversation
There was a problem hiding this comment.
Pull request overview
Disables Nix import-from-derivation (IFD) for this flake/CI and switches the gomod2nix input to a forked source, aligning with the goal of re-enabling Go caching while avoiding IFD.
Changes:
- Set
nixConfig.allow-import-from-derivation = falseinflake.nix. - Switch
gomod2nixflake input fromnix-communitytoUnstoppableMango(and updateflake.lockaccordingly). - Add
allow-import-from-derivation = falseto the CI build job’s Nix configuration.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flake.nix | Disables IFD via nixConfig and repoints gomod2nix to a fork. |
| flake.lock | Locks the new gomod2nix fork revision/hash. |
| .github/workflows/ci.yml | Disables IFD in the CI build job’s Nix config. |
6e5069d to
45a4836
Compare
c7f7102 to
6739f58
Compare
6739f58 to
a1703db
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes disable import-from-derivation in the flake and CI build configuration. The flake switches the ChangesNix build configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This updates Nix evaluation policy, changes the gomod2nix source, and excludes Claude skills from formatting. No concrete merge-blocking risk remains in the supplied change context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dba087c to
272d2cd
Compare
272d2cd to
a62ed4b
Compare
Summary by CodeRabbit