Skip to content

No allow import from derivation - #15

Merged
UnstoppableMango merged 2 commits into
mainfrom
ifd
Sep 14, 2026
Merged

UnstoppableMango merged 2 commits into
mainfrom
ifd

Conversation

@UnstoppableMango

@UnstoppableMango UnstoppableMango commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor
  • Initial vibe
  • Re-enable go cache

Summary by CodeRabbit

  • Chores
    • Updated build configuration to improve reliability and reproducibility of automated checks.
    • Improved consistency of development and CI environment configuration.
    • Updated code-formatting exclusions to prevent generated or tool-specific files from being modified automatically.

Copilot AI review requested due to automatic review settings July 19, 2026 00:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables Nix import-from-derivation (IFD) for this flake/CI and switches the gomod2nix input to a forked source, aligning with the goal of re-enabling Go caching while avoiding IFD.

Changes:

  • Set nixConfig.allow-import-from-derivation = false in flake.nix.
  • Switch gomod2nix flake input from nix-community to UnstoppableMango (and update flake.lock accordingly).
  • Add allow-import-from-derivation = false to the CI build job’s Nix configuration.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
flake.nix Disables IFD via nixConfig and repoints gomod2nix to a fork.
flake.lock Locks the new gomod2nix fork revision/hash.
.github/workflows/ci.yml Disables IFD in the CI build job’s Nix config.

Comment thread .github/workflows/ci.yml
Comment thread flake.nix
@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0ccbdb9e-b66d-4d2f-9e6a-e6b6d8bff359

📥 Commits

Reviewing files that changed from the base of the PR and between a1703db and dba087c.

📒 Files selected for processing (1)
  • flake.nix

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes disable import-from-derivation in the flake and CI build configuration. The flake switches the gomod2nix input to the UnstoppableMango/gomod2nix repository and excludes .claude/skills/** from treefmt formatting.

Changes

Nix build configuration

Layer / File(s) Summary
Nix evaluation policy
.github/workflows/ci.yml, flake.nix
The flake and CI build job set allow-import-from-derivation = false.
gomod2nix source
flake.nix
The gomod2nix input now uses the UnstoppableMango/gomod2nix repository on the main branch.
treefmt exclusion
flake.nix
The treefmt configuration excludes .claude/skills/** from formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to dba08

This updates Nix evaluation policy, changes the gomod2nix source, and excludes Claude skills from formatting. No concrete merge-blocking risk remains in the supplied change context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change: disabling import-from-derivation in CI and the flake configuration. The wording is grammatically awkward but remains clear and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ifd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@UnstoppableMango
UnstoppableMango force-pushed the ifd branch 2 times, most recently from dba087c to 272d2cd Compare September 14, 2026 00:51
@UnstoppableMango
UnstoppableMango merged commit 890ab4a into main Sep 14, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants