Repository navigation
fix(nix): preserve native fetch decoding after importing Undici - #422
Merged
Merged
Conversation
Undici 8.11.0 changes the global dispatcher when the Nix package is imported. Its compatibility wrapper loses response headers over HTTP/2, so Node's native fetch passes compressed token responses to the JSON parser. Cache publication then fails before authentication completes. Require Undici 8.11.2, which includes the upstream dispatcher repair. A local TLS reproduction fails with 8.11.0 and decodes the compressed JSON response successfully with 8.11.2.
iainlane
force-pushed
the
codex/fix-undici-native-fetch
branch
from
September 27, 2026 16:27
d055b83 to
4807ff6
Compare
iainlane
enabled auto-merge
September 27, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache publication fails while parsing
/tokenresponses after the dependency update in #418. Importing@cupboard/nixloads Undici 8.11.0, whose compatibility dispatcher loses HTTP/2 response headers. Node's nativefetchthen passes compressed bytes to the JSON parser.Require Undici 8.11.2, which includes the upstream repair, and regenerate the Nix dependency hash.
A local TLS reproduction fails with 8.11.0 and decodes the compressed JSON response successfully with 8.11.2. The full
pnpm checkpassed under Nix Node 24.19.0 and pnpm 12.6.0, andnix build .#cupboard --no-linkpassed. Both dependency-hash fetches agreed.The shared cache publisher uses the reusable workflow and CLI from
main. The publication job on #418 therefore exercised the older CLI before merge; this PR's publication job also uses the current, unfixed CLI. After merge, verify publication from current main. Any affected open PR needs a complete workflow rerun to resolve the updated publisher; rerunning only failed jobs reuses the original workflow revision.Upstream: dispatcher header repair and native fetch compression regression.