Repository navigation
MAT-91342: wrap nucleic acid sequence rows in a snake pattern - #169
spot-uncountable wants to merge 5 commits into
Conversation
In sequence mode, every second row of a nucleic acid chain now runs right to left, so the sequence continues from the end of the row above. The row direction applies to every item in the row, including the caret slot, and caret navigation follows the drawn columns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regenerate the 22 Playwright snapshots whose nucleic acid rows now wrap in a snake pattern: the ruler, sequence-mode, antisense, and sequence copy-paste cases. The images come from the CI Playwright container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The full Playwright run on c0b890c failed three screenshot checks that show the reversed second row: Ketcher 3.1.0 bugs Case 14, Ketcher 3.5.0 bugs Case 19, and Ruler Case 16 screenshot 1. The new images come from that run. Ruler Case 16 screenshot 1 keeps the 527 px canvas height of the full run, because the Calculate Properties window is still opening when the test takes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
FullScale result for cf5a037 (run 38019637503), compared to fork master run 37065340895 and other recent runs: Failures from the snake-row change (fixed in 602fa85)
Failures not from this change
Next: the FullScale run on 602fa85. |
calculateProperties waits only 1 second for the result. For the 1001-nucleotide structure the properties window can finish after the first screenshot, so the canvas height changes between the first ruler drag and its scroll. Wait for the gross formula, then refresh screenshots 1 and 2 for the settled canvas height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
FullScale result for 602fa85 (run 38037050894), compared to fork master runs: Ruler Case 16 (the one failure from the snake-row change), fixed in 04cb3a6. The first ruler drag scrolls with the canvas height at that moment. Other failures match the master baseline:
|
|
Correction to the comment above: the shard 1 auto-mapping test ( |
|
FullScale result for 04cb3a6 (run 38047025758), compared to the earlier runs of this PR and to fork master runs:
The PR has no failure that its change causes, and it is ready for review. |
Description
In sequence mode, every second row of an RNA or DNA chain now runs right to left, so the sequence continues from the end of the row above. The direction belongs to the row, so the caret slot and every item type in the row move with the bases, and caret navigation follows the drawn columns.
Decisions for the reviewer to confirm:
This replaces #168. That PR reversed only the nucleotide renderers, so the caret slot at the chain end and the other item types stayed in the left-to-right columns.
Context: Evan Hammerstein asked for wrapped RNA rows to follow a snake pattern. Slack thread
Ticket: MAT-91342
What did I (author) test?
Testing recommendations and risks (for reviewers)
Reproduce the issue (on the base branch):
Abases.With this change, row 2 starts under base 30 and runs right to left.
Checked live in the platform Chemical Search drawer, with the
ketcher-corebuild of this branch in the served vendor bundle:Gat the endGis added to the left of base 41The new
__tests__/unc-regression/sequence-snake-rows.test.tspasses, and so do the existing__tests__/application/render/renderers/sequenceand__tests__/unc-regressionjest suites. A CI run of the sequence-mode, ruler, antisense, and sequence copy-paste Playwright specs passed with updated snapshots. This PR updates the 22 snapshots that changed because nucleic acid rows now alternate direction. The run also changed 5 sequence-edit snapshots because an earlier peptide test in the same worker left the editor in peptide mode. Those 5 snapshots stay unchanged.E2E gate declaration:
Main gets this change with the next Ketcher version bump after a fork release.
Spot Dot (Claude Opus 5.5)
🤖 Generated with Claude Code