Repository navigation
Conversation
…add shards The fork changed the S-Group dialog's default type from Data to SRU, in 1a41ba3 "clear history stack". Upstream's specs open the type dropdown by clicking the span that shows the current type, matched on the text "Data", so every one of them waits 60 seconds and fails. That is 168 of the click timeouts CI reports. They now use the s-group-type-input-span test id, which this repo already uses elsewhere and which does not depend on which type is the default. Locally the Multiple S-Group file goes from 11 click timeouts to 0, and from 3.3 minutes to 25 seconds. Shard 6 of 6 has never finished: master's last three runs and every PR run hit the 120 minute cap and were cancelled without a summary, so a sixth of the suite has no history to compare against. Ten shards bring each one back under an hour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Two changes that stop the Playwright suite reporting failures that are not about the
code under test. Every recent PR fails a large batch of specs, which makes the suite
useless as a gate — telling a real regression from the noise currently takes a manual
run-to-run diff.
The S-Group specs assume a default this fork changed
1a41ba32e("clear history stack") changed the S-Group dialog's default type:Upstream's specs open the type dropdown by clicking the span that shows the current
type, matched on the literal text
'Data'. On this fork that span reads "SRU polymer",so the click waits the full 60 seconds and the test fails. That accounts for 168 of
the click timeouts CI reports.
The helpers now use the
s-group-type-input-spantest id, which this repo already usesin
is-query-structure-selected.spec.tsands-group-click-atom-bond.spec.ts. They nolonger depend on which type is the default, so they work on the fork and would work
upstream. The
textparameter every caller passed as'Data'is gone with it.Measured locally on
multiple-s-group-tool.spec.ts:Shard 6 of 6 has never finished
Master's last three runs and every PR run hit the 120-minute cap on
part (6, 6)andwere cancelled without printing a summary. A sixth of the suite therefore has no history
at all, so its failures cannot be compared against anything — that is why #115's CI
looked far worse than master's when the two are in fact almost identical.
Ten shards bring each one back under an hour.
Test plan
multiple-s-group-tool.spec.tslocally, against a standalone build: 11 click timeoutsto 0. The 11 remaining failures are
A snapshot doesn't exist, from Playwright lookingfor
-chromium-darwin.pngon macOS; that cannot happen on Linux CI.npx tsc --noEmitandeslintclean over the changed specs.Not included
About 150 screenshot comparison failures remain, concentrated in
toggle-explicit-hydrogens,image-filesandcalculate-cip-tool— the areas where thefork deliberately changed what gets drawn (Indigo hydrogen label default, CIP
descriptors, S-group brackets) without regenerating upstream's committed snapshots.
Those need a scoped, reviewed regeneration, as a snapshot-only PR. Doing it before this
one lands would mean guessing at the list, since the current failure picture comes from
runs where a sixth of the suite never reported and every S-Group spec was timing out.
Check list
#1234 – issue name🤖 Generated with Claude Code