comment adds new comment with every commit

[maxkarkowski]

since we updated changesets-gitlab we have now the issue that with every commit the changesets-gitlab comment command creates a new comment in our merge request. before the update it only created one comment for a merge request.

[JounQin]

Any screenshot?

Should be related to #138 or #143(most likely)

cc @alan910127

[alan910127]

Hello @maxkarkowski, are you upgraded from v0.11.0 or v0.10.x?
This information can help me locate the issue faster 😄

[maxkarkowski]

hey @alan910127 sorry of course i can. we are currently on version 0.10.3

Update:
update to latest version and the problem is still there

[maxkarkowski]

Any screenshot?

Should be related to #138 or #143(most likely)

cc @alan910127

here is a screenshot

[maxkarkowski]

but even if there is a changeset found, new comment will appear with everey command run

[alan910127]

Hey @maxkarkowski, I couldn't reproduce the error on a project created on gitlab.com. Could you provide some information that might be related to this issue?

Here's something I think might be relevant:

• CI_MERGE_REQUEST_IID predefined variable
• Discussions API

[idumancic]

@alan910127 I have the same problem, we are using a self-hosted instance of GitLab if that helps, but when I tested on gitlab.com I also did not get any error.

[maxkarkowski]

@alan910127 I have the same problem, we are using a self-hosted instance of GitLab if that helps, but when I tested on gitlab.com I also did not get any error.

we are also using a self hosted gitlab

[maxkarkowski]

Hey @maxkarkowski, I couldn't reproduce the error on a project created on gitlab.com. Could you provide some information that might be related to this issue?

Here's something I think might be relevant:

• CI_MERGE_REQUEST_IID predefined variable
• Discussions API

this is the comment job we have . it runs on every merge request

comment:
  rules:
    - if: '$CI_MERGE_REQUEST_IID && $CI_COMMIT_BRANCH != "changeset-release/main"'
  extends:
    - .init-pnpm
  script:
    - pnpm changesets-gitlab comment # comment automatically like https://github.com/changesets/bot
    
.init-pnpm:
  before_script:
    - corepack enable
    - corepack prepare pnpm@8.5.1 --activate
    - node --max-old-space-size=8192
    - pnpm config set store-dir .pnpm-store
    - pnpm install # install dependencies
  cache:
    key:
      files:
        - pnpm-lock.yaml
    paths:
      - .pnpm-store

[alan910127]

Got it. I will try to spin up a self-hosted GitLab instance and test the issue inside that.
What's your GitLab version in case it helps?

[maxkarkowski]

Got it. I will try to spin up a self-hosted GitLab instance and test the issue inside that. What's your GitLab version in case it helps?

ist GitLab Community Edition v16.6.0

[JounQin]

I may have opportunity to test and debug this issue on our internal GitLab service today, I'll try to give a fix soon.

---

I'm meeting bigger issues...:

[alan910127]

@JounQin I have found that the /projects/:id/merge_requests/:merge_request_iid/diffs is only available on GitLab 15.7 or above.
However, it's not documented very well though 😕, there is only a mention at the docs for changes API.

Reverting #143 could solve the 404 issue and potentially this issue as well.

---

Update:

Using changesets-gitlab@0.11.0 in a GitLab 13 instance does not have the issue of commenting repeatedly.
So, reverting #143 should also solve this one, but there will always be a deprecation warning in the pipeline though 😅.