Skip to content

fix(directory): harden VMACS query construction #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlorenzo wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(directory): harden VMACS query construction #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web/Areas/Directory/Services/VMACSService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ namespace Viper.Areas.Directory.Services
{
public class VMACSService
{
// Fixed token required by the internal VMACS trust endpoint (not a rotating secret).
private const string VmacsAuthToken = "06232005";

@rlorenzo rlorenzo Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsedwards Should this be a config value?


private static HttpClient sharedClient = new()
{
BaseAddress = new Uri("https://vmacs-vmth.vetmed.ucdavis.edu"),
Expand All @@ -21,7 +24,8 @@ protected VMACSService() { }
public static async Task<VMACSQuery?> Search(String? loginID)
{

string request = $"/trust/query.xml?dbfile=3&index=CampusLoginId&find={loginID}&format=CHRIS4&AUTH=06232005".ToString();
string encodedLoginId = Uri.EscapeDataString(loginID ?? string.Empty);
string request = $"/trust/query.xml?dbfile=3&index=CampusLoginId&find={encodedLoginId}&format=CHRIS4&AUTH={VmacsAuthToken}";
using HttpResponseMessage response = await sharedClient.GetAsync(request);
if (!response.IsSuccessStatusCode)
{
Expand Down
Loading