Bump tools to v0.44.0#10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Go tooling dependencies (notably golang.org/x/tools) and enhances type-check error reporting when a template references a missing field/method by including source declaration info and listing available exported members. Tests and the public example are updated to keep outputs deterministic and validate the improved error messages.
Changes:
- Bump
golang.org/x/toolstov0.44.0(and relatedx/mod,x/syncupdates) and refreshgo.sum. - Improve “identifier not found” errors to include declared-at location and an
available:exported members list. - Update tests and
ExampleExecuteoutput handling to match the new error formatting.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Bumps golang.org/x/tools to v0.44.0 and updates indirect deps. |
go.sum |
Adds checksums for the newly required module versions. |
check.go |
Adds richer not-found formatting and member collection used in error messages. |
check_test.go |
Updates assertions and adds coverage for the new not-found messaging details. |
example_test.go |
Makes example output deterministic by stripping declared-at location and updates expected output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+151
| if f.Embedded() { | ||
| if inner, ok := f.Type().Underlying().(*types.Struct); ok { | ||
| g.collectStructFields(inner, seen, members) | ||
| } | ||
| continue |
Comment on lines
+82
to
+90
| func (g *Global) formatNotFound(ident string, tp types.Type) string { | ||
| var buf strings.Builder | ||
| buf.WriteString(ident) | ||
| buf.WriteString(" not found on ") | ||
| buf.WriteString(g.TypeString(tp)) | ||
| if named, ok := tp.(*types.Named); ok { | ||
| pos := g.fileSet.Position(named.Obj().Pos()) | ||
| if pos.IsValid() { | ||
| fmt.Fprintf(&buf, " (declared at %s)", pos) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.