PyCharm gets weird about self.request.GET.get

[Crocmagnon]

Bug report

What's wrong

class ArticleDetailView(generic.DetailView):
    model = Article

    def get_queryset(self):
        key = self.request.GET.get("draft_key")

PyCharm complains about the types here, even though mypy doesn't.

Hinting request: WSGIRequest solves the issue with PyCharm though.

How is that should be

There should not be any issue with the types. Is PyCharm wrong about complaining here? Is django-stubs wrong about typing request with HttpRequest and not something else like WSGIRequest?

System information

• OS: macOS 12.1 (21C52)
• python version: Python 3.10.0
• django version: 4.0
• mypy version: mypy 0.930
• django-stubs version: 1.9.0
• django-stubs-ext version: 0.3.1

[sobolevn]

Can you please paste reveal_type(self.request)? What it was initially?

Looks related to python/typeshed#6597

[Crocmagnon]

src/articles/views/html.py:133: note: Revealed type is "django.http.request.HttpRequest"

My guess is that comes from the existing type hinting in TemplateResponseMixin:

django-stubs/django-stubs/views/generic/base.pyi

Line 27 in 9483865

request: http.HttpRequest = ...

[sobolevn]

Ok, here's what I think is going on.

HttpRequest has .GET defined QueryDict, which is a MuttableMapping subtype:

django-stubs/django-stubs/utils/datastructures.pyi

Line 36 in 9483865

class MultiValueDict(MutableMapping[_K, _V]):

Related python/typeshed#6694

[Crocmagnon]

So it’s an error in pycharm? As a matter of fact I don’t understand their message. My .get call looks fine according to their pop up, right?

It nearly seems like they think I’m missing the self, like if GET were a type, not an instance. I’ll try to check the revealed type of GET

[sobolevn]

It looks like it is a error with PyCharm. Do they use our stubs? Or do the use their own version?

You can send a PR with this sample as a test case (if we don't have one). Just to be sure.

[Crocmagnon]

This looks related to #555, this thread and this YouTrack issue. Nothing we can fix here I'm afraid.

BTW, Revealed type is "django.http.request.QueryDict" in both cases (with HttpRequest or WSGIRequest as type for self.request).