Repository navigation
Fix: filter empty strings in sync auth status after disconnect - #198
Merged
tylergraydev merged 1 commit intoApr 14, 2026
Merged
Conversation
disconnect_cloud_sync sets sync_gist_id to "" rather than deleting
it. Since get_setting returns Some("") for empty values, the
is_authenticated check (token.is_some() && gist_id.is_some())
incorrectly returns true after disconnect.
Add .filter(|s| !s.is_empty()) to all get_setting calls in
get_sync_auth_status, matching the pattern already used in
get_sync_status.
Relates to tylergraydev#195
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tylergraydev
approved these changes
Apr 14, 2026
tylergraydev
left a comment
tylergraydev
left a comment
Owner
There was a problem hiding this comment.
Clean fix. The .filter(|s| !s.is_empty()) pattern matches the existing usage at lines 335-336 in get_sync_status. Root cause is well-explained in the PR description.
LGTM, merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnect_cloud_syncsetssync_gist_idto""(nodelete_settingmethod exists)get_sync_auth_statuscheckedgist_id.is_some()without filtering empty stringsSome("")passes theis_some()check, sois_authenticatedstayedtrueafter disconnect.filter(|s| !s.is_empty())to allget_settingcalls, matching the pattern already used inget_sync_statusTest plan
Relates to #195
🤖 Generated with Claude Code