Merged
Conversation
📊 Benchmark Results
PR branch
|
| Method | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Gen1 | Allocated |
|---|---|---|---|---|---|---|---|
| InputDigitPerKeystroke | 1000 | 4.648 ms | 0.0717 ms | 0.0670 ms | 242.1875 | 7.8125 | 3.9 MB |
BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32860/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
Job-AMQORM : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
Runtime=.NET 10.0 InvocationCount=1 IterationCount=20
LaunchCount=1 RunStrategy=ColdStart UnrollFactor=1
WarmupCount=1
| Method | Mean | Error | StdDev | Allocated |
|---|---|---|---|---|
| CreateInstance | 328.2 μs | 109.4 μs | 126.0 μs | 75.05 KB |
| CreateInstanceAndLoadAllRegions | 8,450.9 μs | 492.5 μs | 567.1 μs | 1576.63 KB |
| FirstRegionLookup | 353.9 μs | 133.2 μs | 153.4 μs | 80.11 KB |
BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32860/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
.NET 10.0 : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
Job=.NET 10.0 Runtime=.NET 10.0
| Method | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Allocated |
|---|---|---|---|---|---|---|
| ExtractPossibleNumber_CleanInput | 1000 | 22.50 μs | 0.030 μs | 0.027 μs | - | - |
| ExtractPossibleNumber_WithLeadingJunk | 1000 | 37.15 μs | 0.741 μs | 1.627 μs | 2.8687 | 48360 B |
BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32860/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
.NET 10.0 : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
Job=.NET 10.0 Runtime=.NET 10.0
| Method | PhoneNumberCount | Mean | Error | StdDev | Median | Gen0 | Allocated |
|---|---|---|---|---|---|---|---|
| FindNumbers_Valid | 100 | 166.8 μs | 4.14 μs | 12.20 μs | 160.6 μs | 4.1504 | 69.93 KB |
| FindNumbers_StrictGrouping | 100 | 325.2 μs | 1.89 μs | 1.77 μs | 325.0 μs | 7.3242 | 123.3 KB |
BenchmarkDotNet v0.15.8, Windows 11 (10.0.26100.32860/24H2/2024Update/HudsonValley) (Hyper-V)
AMD EPYC 7763 2.44GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.301
[Host] : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
.NET 10.0 : .NET 10.0.9 (10.0.9, 10.0.926.27113), X64 RyuJIT x86-64-v3
Job=.NET 10.0 Runtime=.NET 10.0
| Method | PhoneNumberCount | Mean | Error | StdDev | Gen0 | Allocated |
|---|---|---|---|---|---|---|
| ParseValidateAndFormatPhoneNumbers | 1000 | 2.608 ms | 0.0520 ms | 0.0694 ms | 35.1563 | 582.48 KB |
| ParseValidateAndFormatPhoneNumbers | 10000 | 24.619 ms | 0.1398 ms | 0.1168 ms | 343.7500 | 5818.97 KB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 97.94% 98.08% +0.13%
==========================================
Files 40 40
Lines 52949 52957 +8
Branches 1124 1124
==========================================
+ Hits 51862 51941 +79
+ Misses 852 772 -80
- Partials 235 244 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
twcclegg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes