Skip to content

Conversation

@jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Mar 10, 2023

Description

the description says

"Instead of adding .carousel-dark, set data-bs-theme="dark" on the root element, a parent wrapper, or the component itself. "

but it does not work on the element itself

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

fix  data-bs-theme="dark" on component itself
@jonnysp jonnysp requested a review from a team as a code owner March 10, 2023 11:02
@mdo
Copy link
Member

mdo commented Mar 10, 2023

Thanks for this! Also noting that we may need to do this on other components.

@mdo mdo merged commit 9c0b2be into twbs:main Mar 10, 2023
@jonnysp jonnysp deleted the carousel-dark branch March 11, 2023 08:41
@jonnysp
Copy link
Contributor Author

jonnysp commented Mar 11, 2023

that can be, at modal and card the text color are not taken over, in addition a workaround #38212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants