Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 5, 2023

Description

This PR removes some CSS code used to define .highlight-toolbar:

  • border: solid var(--bs-border-color); can be dropped safely since it's the default border color
  • border-width: 1px 0; is replaced by border-0 border-top border-bottom
  • .btn-clipboard { margin-top: 0; margin-right: 0 } is useless because we already use utilities in this case

<button type="button" class="btn-clipboard mt-0 me-0" title="Copy to clipboard">

Motivation & Context

Less CSS and more utilities

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond requested a review from a team as a code owner January 5, 2023 20:38
@mdo mdo merged commit 1b83ab2 into main Jan 6, 2023
@mdo mdo deleted the main-jd-remove-css-from-highlight-toolbar branch January 6, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants