Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 29, 2022

Following up https://github.com/twbs/bootstrap/pull/37759/files.

This PR suggests to handle different colors for the links within the callouts based on light/dark mode to avoid the following use cases.

Before

Screenshot 2022-12-29 at 21 35 54
Screenshot 2022-12-29 at 21 35 48
Screenshot 2022-12-29 at 21 35 08
Screenshot 2022-12-29 at 21 34 57

Now

Warning callout

Screenshot 2022-12-29 at 21 37 23
Screenshot 2022-12-29 at 21 37 16

Info callout

@mdo
Copy link
Member

mdo commented Dec 29, 2022

Ayy thanks!

@julien-deramond julien-deramond marked this pull request as ready for review December 29, 2022 20:42
@julien-deramond julien-deramond requested a review from a team as a code owner December 29, 2022 20:42
@mdo mdo merged commit 1a043b5 into main Dec 29, 2022
@mdo mdo deleted the main-jd-improve-callout-links-on-dark-mode branch December 29, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants